From: Jiri Slaby <jirislaby@kernel.org>
To: nicolas.bouchinet@clip-os.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Luis Chamberlain <mcgrof@kernel.org>, Kees Cook <kees@kernel.org>,
Joel Granados <j.granados@samsung.com>,
Neil Horman <nhorman@tuxdriver.com>,
Andrew Morton <akpm@linux-foundation.org>,
Lin Feng <linf@wangsu.com>, Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH 3/3] tty: ldsic: fix tty_ldisc_autoload sysctl's proc_handler
Date: Wed, 13 Nov 2024 10:08:43 +0100 [thread overview]
Message-ID: <9bb4de26-9053-4abd-a319-3e4361784ecb@kernel.org> (raw)
In-Reply-To: <20241112131357.49582-4-nicolas.bouchinet@clip-os.org>
On 12. 11. 24, 14:13, nicolas.bouchinet@clip-os.org wrote:
> From: Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>
>
> Commit 7c0cca7c847e ("tty: ldisc: add sysctl to prevent autoloading of
> ldiscs") introduces the tty_ldisc_autoload sysctl with the wrong
> proc_handler. .extra1 and .extra2 parameters are set to avoid other values
> thant SYSCTL_ZERO or SYSCTL_ONE to be set but proc_dointvec do not uses
> them.
>
> This commit fixes this by using proc_dointvec_minmax instead of
> proc_dointvec.
>
> Fixes: 7c0cca7c847e ("tty: ldisc: add sysctl to prevent autoloading of ldiscs")
> Signed-off-by: Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
I hope noone managed to store 2+ to that sysctl yet...
thanks,
--
js
suse labs
prev parent reply other threads:[~2024-11-13 9:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 13:13 [PATCH 0/3] Fixes multiple sysctl proc_handler usage error nicolas.bouchinet
2024-11-12 13:13 ` [PATCH 1/3] coredump: Fixes core_pipe_limit sysctl proc_handler nicolas.bouchinet
2024-11-13 2:35 ` Lin Feng
2024-11-13 14:15 ` Nicolas Bouchinet
2024-11-14 1:34 ` Lin Feng
2024-11-14 14:25 ` Nicolas Bouchinet
2024-11-12 13:13 ` [PATCH 2/3] sysctl: Fix underflow value setting risk in vm_table nicolas.bouchinet
2024-11-13 2:37 ` Lin Feng
2024-11-12 13:13 ` [PATCH 3/3] tty: ldsic: fix tty_ldisc_autoload sysctl's proc_handler nicolas.bouchinet
2024-11-13 2:39 ` Lin Feng
2024-11-13 9:08 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bb4de26-9053-4abd-a319-3e4361784ecb@kernel.org \
--to=jirislaby@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=j.granados@samsung.com \
--cc=jack@suse.cz \
--cc=kees@kernel.org \
--cc=linf@wangsu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=nicolas.bouchinet@clip-os.org \
--cc=nicolas.bouchinet@ssi.gouv.fr \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®