mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Hunter <david.hunter.linux@gmail.com>
To: sukrut heroorkar <hsukrut3@gmail.com>
Cc: Dave Kleikamp <shaggy@kernel.org>,
	Rand Deeb <rand.sec96@gmail.com>,
	Edward Adam Davis <eadavis@qq.com>,
	Ghanshyam Agrawal <ghanshyam1898@gmail.com>,
	Nihar Chaithanya <niharchaithanya@gmail.com>,
	Vasiliy Kovalev <kovalev@altlinux.org>,
	Arnaud Lecomte <contact@arnaud-lcm.com>,
	"open list:JFS FILESYSTEM" <jfs-discussion@lists.sourceforge.net>,
	open list <linux-kernel@vger.kernel.org>,
	skhan@linux.foundation.org,
	syzbot+4b717071f1eecb2972df@syzkaller.appspotmail.com
Subject: Re: [PATCH] jfs: validate budmin to prevent shift-out-of-bounds in dbAllocAG()
Date: Wed, 22 Oct 2025 09:22:28 -0400	[thread overview]
Message-ID: <9bb82a26-c0e7-4e3f-abce-0ef07e1cff66@gmail.com> (raw)
In-Reply-To: <CAHCkknr6o_9zO+DYRaf-W7C46r17JUf2MFnPLm1dik=ei=LxcA@mail.gmail.com>

On 10/19/25 05:42, sukrut heroorkar wrote:
> Hi David,
> On Sun, Oct 19, 2025 at 12:50 AM David Hunter
> <david.hunter.linux@gmail.com> wrote:
>>
>> On 10/18/25 01:30, Sukrut Heroorkar wrote:
>>> Tested-by: syzbot+4b717071f1eecb2972df@syzkaller.appspotmail.com
>>
>>
>> Hey Sukrut,
>>
>> Did you do any other testing other than syzbot testing?
> I also used the C reproducer to test my fix locally with QEMU and it
> no longer triggers error. Do you recommend any
> other tests? Please let me know.
> Thanks,
> Sukrut.
>> Thanks,
>> David Hunter


Hey Sukrut,

You always need to do testing to ensure that your code does not bring in
regressions into the kernel. If doing things to file systems, xfstests
is at least the basic testing that you should do. You can also search to
see if any other publicly tools are available and/or applicable, but
xfstests are the minimum.

Thanks,
David Hunter

      reply	other threads:[~2025-10-22 13:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-18  5:30 Sukrut Heroorkar
2025-10-18 19:19 ` David Hunter
2025-10-19  9:42   ` sukrut heroorkar
2025-10-22 13:22     ` David Hunter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bb82a26-c0e7-4e3f-abce-0ef07e1cff66@gmail.com \
    --to=david.hunter.linux@gmail.com \
    --cc=contact@arnaud-lcm.com \
    --cc=eadavis@qq.com \
    --cc=ghanshyam1898@gmail.com \
    --cc=hsukrut3@gmail.com \
    --cc=jfs-discussion@lists.sourceforge.net \
    --cc=kovalev@altlinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=niharchaithanya@gmail.com \
    --cc=rand.sec96@gmail.com \
    --cc=shaggy@kernel.org \
    --cc=skhan@linux.foundation.org \
    --cc=syzbot+4b717071f1eecb2972df@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®