mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Stanner <phasta@mailbox.org>
To: "Christian König" <christian.koenig@amd.com>,
	phasta@kernel.org, "Baineng Shou" <shoubaineng@gmail.com>,
	"Sumit Semwal" <sumit.semwal@linaro.org>
Cc: Tvrtko Ursulin <tursulin@ursulin.net>,
	Akash Goel <akash.goel@arm.com>,
	 linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
	 linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org,
	 stable@vger.kernel.org
Subject: Re: [PATCH] dma-fence: Make dma_fence_dedup_array() robust against 0-count input
Date: Mon, 29 Jun 2026 12:16:02 +0200	[thread overview]
Message-ID: <9bd4bd923eacca9da25b6b9fda33057455d084c3.camel@mailbox.org> (raw)
In-Reply-To: <349ada65-c788-4c5e-9992-0278cf1382dd@amd.com>

On Mon, 2026-06-29 at 11:52 +0200, Christian König wrote:
> On 6/29/26 11:06, Philipp Stanner wrote:
> > On Mon, 2026-06-29 at 10:52 +0200, Christian König wrote:
> > > On 6/29/26 10:49, Philipp Stanner wrote:
> > > > > 
> > > > > I will add a CC stable before pushing to drm-misc-fixes.
> > > > 
> > > > No offense intended or taken, but don't the DRM rules say that
> > > > things
> > > > do not get merged while there are outstanding concerns or
> > > > significant
> > > > points in review feedback?
> > > 
> > > I haven't seen that before writing the response.
> > > 
> > > I usually go over my mails till the end and wait a couple of
> > > hours before pushing anything.
> > > 
> > > > What about my comments?
> > > 
> > > Looks valid to me as well, but I think that is a separate issue.
> > 
> > But if we keep it an integer for now, and if that check is added,
> > and
> > it most certainly should also catch negative integers, shouldn't
> > it?
> 
> Maybe with a WARN_ON(), but not as regular code path.
> 
> The thing is I think we need to backport this fix to stable kernels,
> but switching from signed to unsigned is only a minor cleanup when no
> real users are currently affected.

Fine by me.

P.

  reply	other threads:[~2026-06-29 10:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29  3:13 Baineng Shou
2026-06-29  6:59 ` Philipp Stanner
2026-06-29  8:45 ` Christian König
2026-06-29  8:49   ` Philipp Stanner
2026-06-29  8:52     ` Christian König
2026-06-29  9:06       ` Philipp Stanner
2026-06-29  9:52         ` Christian König
2026-06-29 10:16           ` Philipp Stanner [this message]
2026-06-29 11:51             ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bd4bd923eacca9da25b6b9fda33057455d084c3.camel@mailbox.org \
    --to=phasta@mailbox.org \
    --cc=akash.goel@arm.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=phasta@kernel.org \
    --cc=shoubaineng@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=sumit.semwal@linaro.org \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®