* [PATCH] media: chips-media: wave5: remove duplicate check
@ 2023-11-28 14:39 Dan Carpenter
2023-12-07 19:08 ` Nicolas Dufresne
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2023-11-28 14:39 UTC (permalink / raw)
To: Nas Chung
Cc: Jackson Lee, Mauro Carvalho Chehab, linux-media, linux-kernel,
kernel-janitors
We already verified that "ret" is zero a few lines earlier. Delete this
duplicate check.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/media/platform/chips-media/wave5/wave5-hw.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/media/platform/chips-media/wave5/wave5-hw.c b/drivers/media/platform/chips-media/wave5/wave5-hw.c
index 3fcb2d92add8..f1e022fb148e 100644
--- a/drivers/media/platform/chips-media/wave5/wave5-hw.c
+++ b/drivers/media/platform/chips-media/wave5/wave5-hw.c
@@ -578,9 +578,6 @@ int wave5_vpu_dec_init_seq(struct vpu_instance *inst)
dev_dbg(inst->dev->dev, "%s: init seq sent (queue %u : %u)\n", __func__,
p_dec_info->instance_queue_count, p_dec_info->report_queue_count);
- if (ret)
- return ret;
-
return 0;
}
--
2.42.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] media: chips-media: wave5: remove duplicate check
2023-11-28 14:39 [PATCH] media: chips-media: wave5: remove duplicate check Dan Carpenter
@ 2023-12-07 19:08 ` Nicolas Dufresne
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Dufresne @ 2023-12-07 19:08 UTC (permalink / raw)
To: Dan Carpenter, Nas Chung
Cc: Jackson Lee, Mauro Carvalho Chehab, linux-media, linux-kernel,
kernel-janitors
Le mardi 28 novembre 2023 à 17:39 +0300, Dan Carpenter a écrit :
> We already verified that "ret" is zero a few lines earlier. Delete this
> duplicate check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> ---
> drivers/media/platform/chips-media/wave5/wave5-hw.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/media/platform/chips-media/wave5/wave5-hw.c b/drivers/media/platform/chips-media/wave5/wave5-hw.c
> index 3fcb2d92add8..f1e022fb148e 100644
> --- a/drivers/media/platform/chips-media/wave5/wave5-hw.c
> +++ b/drivers/media/platform/chips-media/wave5/wave5-hw.c
> @@ -578,9 +578,6 @@ int wave5_vpu_dec_init_seq(struct vpu_instance *inst)
> dev_dbg(inst->dev->dev, "%s: init seq sent (queue %u : %u)\n", __func__,
> p_dec_info->instance_queue_count, p_dec_info->report_queue_count);
>
> - if (ret)
> - return ret;
> -
> return 0;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-07 19:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-28 14:39 [PATCH] media: chips-media: wave5: remove duplicate check Dan Carpenter
2023-12-07 19:08 ` Nicolas Dufresne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®