mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	kernel-dev@igalia.com,
	Boris Brezillon <boris.brezillon@collabora.com>,
	Bradley Morgan <include@grrlz.net>, Chia-I Wu <olv@google.com>,
	Liviu Dudau <liviu.dudau@arm.com>,
	Matthew Brost <matthew.brost@intel.com>,
	Steven Price <steven.price@arm.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Breno Leitao <leitao@debian.org>
Subject: Re: [PATCH v7 3/4] workqueue: Add support for real-time workers
Date: Tue, 3 Nov 2026 11:36:49 +0000	[thread overview]
Message-ID: <9c0fcefa-a40f-4e01-8fab-c079d4697397@igalia.com> (raw)
In-Reply-To: <7fec5fa8362328bf3356a077a8bd9687@kernel.org>


On 26/10/2026 18:37, Tejun Heo wrote:
> Hello, Tvrtko.
> 
> On Sat, Oct 24, 2026 at 09:33:42AM +0100, Tvrtko Ursulin wrote:
>> Can do. I'll get to it the week after next. (Tweaks to other patches in
>> the series as well.) Should I switch to a different base branch by then?
> 
> I just branched wq/for-7.5. That should work as the base.
> 
>> But if you are curious how much better strict
>> affinity makes them I can measure, it is not a huge effort.
> 
> Yes, numbers with and without strict affinity would be great.

Re-measured submit latencies on three relevant setups:

     us	   7.3.0   WQ_RT   +strict_affinity

    median    30      21          11
     min       2       3           2
     max     1038    941         108
    95pct    2384     49          28
    98pct    2922     63          51

I suppose we can interpret this in two ways. Plain WQ_RT is already a 
huge improvement, and although strict affinity is even better, the twice 
as good median probably isn't a huge selling point. So question is do 
tail latencies above the 98th percentile matter, or are they visible in 
the user experience. That I have no experience to answer.

FWIW I have locally split out the patch which adds strict affinity on 
top of WQ_RT so we can trivially go either way.

>> Hmm.. I could do that, but since the tool ships within the kernel does
>> it _need_ to have backward compatibility regarding kernel _internal_
>> implementation details?
> 
> It's just a nice-to-have, but other parts of the script already support
> older kernels, so falling back would be good if it doesn't add too much
> complexity.

Okay done.

Regards,

Tvrtko


  reply	other threads:[~2026-11-03 11:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22  9:38 [PATCH v7 0/4] Realtime workqueues and panthor realtime submission Tvrtko Ursulin
2026-10-22  9:38 ` [PATCH v7 1/4] workqueue: Simplify unbound sysfs attribute registration Tvrtko Ursulin
2026-10-23 13:14   ` Liviu Dudau
2026-10-23 21:04   ` Tejun Heo
2026-10-22  9:38 ` [PATCH v7 2/4] workqueue: Separate sysfs mutable vs immutable wq attribute sanitizing Tvrtko Ursulin
2026-10-23 13:17   ` Liviu Dudau
2026-10-23 21:28   ` Tejun Heo
2026-11-02 18:01     ` Tvrtko Ursulin
2026-10-22  9:38 ` [PATCH v7 3/4] workqueue: Add support for real-time workers Tvrtko Ursulin
2026-10-23 13:23   ` Liviu Dudau
2026-10-23 21:28   ` Tejun Heo
2026-10-24  8:33     ` Tvrtko Ursulin
2026-10-26 18:37       ` Tejun Heo
2026-11-03 11:36         ` Tvrtko Ursulin [this message]
2026-10-22  9:38 ` [PATCH v7 4/4] drm/panthor: Create per queue priority workqueues Tvrtko Ursulin
2026-10-23 13:26   ` Liviu Dudau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c0fcefa-a40f-4e01-8fab-c079d4697397@igalia.com \
    --to=tvrtko.ursulin@igalia.com \
    --cc=boris.brezillon@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=include@grrlz.net \
    --cc=jiangshanlai@gmail.com \
    --cc=kernel-dev@igalia.com \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=matthew.brost@intel.com \
    --cc=olv@google.com \
    --cc=steven.price@arm.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®