From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Vamsi Attunuru <vattunuru@marvell.com>, <arnd@arndb.de>,
<gregkh@linuxfoundation.org>
Cc: <linux-kernel@vger.kernel.org>, <nathan@kernel.org>
Subject: Re: [PATCH] misc: Kconfig: exclude mrvl-cn10k-dpi compilation for 32-bit systems
Date: Wed, 17 Jul 2024 10:50:25 -0700 [thread overview]
Message-ID: <9c13b91e-9efe-4a4f-b0bb-ac148d4f1af2@quicinc.com> (raw)
In-Reply-To: <20240717163739.181236-1-vattunuru@marvell.com>
On 7/17/24 09:37, Vamsi Attunuru wrote:
> Upon adding CONFIG_ARCH_THUNDER & CONFIG_COMPILE_TEST dependency,
> compilation errors arise on 32-bit ARM with writeq() & readq() calls
> which are used for accessing 64-bit values.
>
> Since DPI hardware only works with 64-bit register accesses, using
> CONFIG_64BIT dependency to skip compilation on 32-bit systems.
>
> Fixes: a5e43e2d202d ("misc: Kconfig: add a new dependency for MARVELL_CN10K_DPI")
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> Tested-by: Nathan Chancellor <nathan@kernel.org>
> Tested-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> drivers/misc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index f3bb75384627..41c3d2821a78 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -588,7 +588,7 @@ config NSM
> config MARVELL_CN10K_DPI
> tristate "Octeon CN10K DPI driver"
> depends on PCI
> - depends on ARCH_THUNDER || COMPILE_TEST
> + depends on ARCH_THUNDER || (COMPILE_TEST && 64BIT)
> help
> Enables Octeon CN10K DMA packet interface (DPI) driver which
> intializes DPI hardware's physical function (PF) device's
BTW it looks like you accidentally submitted Makefile.rej, can you
submit a patch to remove it?
commit 5f67eef6dff39421215e9134f1eaae51b67a73b7
Author: Vamsi Attunuru <vattunuru@marvell.com>
Date: Sat Jul 6 08:30:09 2024 -0700
misc: mrvl-cn10k-dpi: add Octeon CN10K DPI administrative driver
...
diff --git a/drivers/misc/Makefile.rej b/drivers/misc/Makefile.rej
new file mode 100644
index 000000000000..a6aaed13f950
--- /dev/null
+++ b/drivers/misc/Makefile.rej
@@ -0,0 +1,7 @@
+--- drivers/misc/Makefile
++++ drivers/misc/Makefile
+@@ -69,3 +69,4 @@ obj-$(CONFIG_TMR_INJECT) += xilinx_tmr_inject.o
+ obj-$(CONFIG_TPS6594_ESM) += tps6594-esm.o
+ obj-$(CONFIG_TPS6594_PFSM) += tps6594-pfsm.o
+ obj-$(CONFIG_NSM) += nsm.o
++obj-$(CONFIG_MARVELL_CN10K_DPI) += mrvl_cn10k_dpi.o
next prev parent reply other threads:[~2024-07-17 17:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 16:37 Vamsi Attunuru
2024-07-17 17:50 ` Jeff Johnson [this message]
2024-07-18 5:05 ` Greg KH
2024-07-18 5:07 ` Greg KH
2024-07-17 18:52 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c13b91e-9efe-4a4f-b0bb-ac148d4f1af2@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®