mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Vamsi Attunuru <vattunuru@marvell.com>,
	arnd@arndb.de, linux-kernel@vger.kernel.org, nathan@kernel.org
Subject: Re: [PATCH] misc: Kconfig: exclude mrvl-cn10k-dpi compilation for 32-bit systems
Date: Thu, 18 Jul 2024 07:07:00 +0200	[thread overview]
Message-ID: <2024071845-grumble-borough-13b4@gregkh> (raw)
In-Reply-To: <2024071839-boundless-wharf-5be0@gregkh>

On Thu, Jul 18, 2024 at 07:05:37AM +0200, Greg KH wrote:
> On Wed, Jul 17, 2024 at 10:50:25AM -0700, Jeff Johnson wrote:
> > On 7/17/24 09:37, Vamsi Attunuru wrote:
> > > Upon adding CONFIG_ARCH_THUNDER & CONFIG_COMPILE_TEST dependency,
> > > compilation errors arise on 32-bit ARM with writeq() & readq() calls
> > > which are used for accessing 64-bit values.
> > > 
> > > Since DPI hardware only works with 64-bit register accesses, using
> > > CONFIG_64BIT dependency to skip compilation on 32-bit systems.
> > > 
> > > Fixes: a5e43e2d202d ("misc: Kconfig: add a new dependency for MARVELL_CN10K_DPI")
> > > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> > > Tested-by: Nathan Chancellor <nathan@kernel.org>
> > > Tested-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> > > ---
> > >   drivers/misc/Kconfig | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> > > index f3bb75384627..41c3d2821a78 100644
> > > --- a/drivers/misc/Kconfig
> > > +++ b/drivers/misc/Kconfig
> > > @@ -588,7 +588,7 @@ config NSM
> > >   config MARVELL_CN10K_DPI
> > >   	tristate "Octeon CN10K DPI driver"
> > >   	depends on PCI
> > > -	depends on ARCH_THUNDER || COMPILE_TEST
> > > +	depends on ARCH_THUNDER || (COMPILE_TEST && 64BIT)
> > >   	help
> > >   	  Enables Octeon CN10K DMA packet interface (DPI) driver which
> > >   	  intializes DPI hardware's physical function (PF) device's
> > 
> > 
> > BTW it looks like you accidentally submitted Makefile.rej, can you submit a
> > patch to remove it?
> 
> That was me, not Vamsi, and should now be gone from the tree, sorry
> about that.

Oops, forgot to push out my local tree, should show up now, sorry about
that.

greg k-h

  reply	other threads:[~2024-07-18  5:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-17 16:37 Vamsi Attunuru
2024-07-17 17:50 ` Jeff Johnson
2024-07-18  5:05   ` Greg KH
2024-07-18  5:07     ` Greg KH [this message]
2024-07-17 18:52 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024071845-grumble-borough-13b4@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nathan@kernel.org \
    --cc=quic_jjohnson@quicinc.com \
    --cc=vattunuru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®