From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Bartosz Golaszewski <brgl@kernel.org>, Mark Brown <broonie@kernel.org>
Cc: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
Baojun Xu <baojun.xu@ti.com>, Sen Wang <sen@ti.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Linus Walleij <linusw@kernel.org>, <linux-sound@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH] ASoC: pcm3168a: don't request the reset GPIO as non-exclusive
Date: Wed, 4 Nov 2026 12:09:32 +0100 [thread overview]
Message-ID: <9c22be49-edc3-41f4-ae72-4749a6b10d0f@intel.com> (raw)
In-Reply-To: <laiektucfxhzdf7ifiypwy6plkifriuovtarzz3qrwyd2yk7ks@3cskrh7fkwbf>
On 11/4/2026 9:06 AM, Bartosz Golaszewski wrote:
> On Wed, Nov 04, 2026 at 12:03:55AM +0000, Mark Brown wrote:
>>> The GPIOD_FLAGS_BIT_NONEXCLUSIVE flag is deprecated and users should
>>> rely on the GPIO shared proxy. All users of this codec driver are ARM64
>>> and this architecture now enables automatically shared GPIOs for
>>> everyone. The driver now longer has to care about the sharing so drop
>>> the flag.
>>
>> sound/soc/intel/avs/boards/pcm3168a.c would beg to differ about this
>> being arm64 only, though that only has one CODEC and shouldn't share the
>> GPIO so it should be fine.
>>
Thank you, Mark, for mentioning this. Indeed, the x86 user (avs-driver)
does not utilize the GPIO but does utilize pcm3168a codec nonetheless.
> Right. Do you want me to resend with commit message amended?
While at it, two nitpicks:
ASoC: pcm3168a: -> ASoC: codecs: pcm3168a:
don't -> do not
(the last one simply makes the greps easier, and is more of a preference
thing).
next prev parent reply other threads:[~2026-11-04 11:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 13:48 Bartosz Golaszewski
2026-11-04 0:03 ` Mark Brown
2026-11-04 8:06 ` Bartosz Golaszewski
2026-11-04 11:09 ` Cezary Rojewski [this message]
2026-11-04 11:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c22be49-edc3-41f4-ae72-4749a6b10d0f@intel.com \
--to=cezary.rojewski@intel.com \
--cc=baojun.xu@ti.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=broonie@kernel.org \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®