[PATCH] ASoC: pcm3168a: don't request the reset GPIO as non-exclusive

[PATCH] ASoC: pcm3168a: don't request the reset GPIO as non-exclusive

[Bartosz Golaszewski]

The GPIOD_FLAGS_BIT_NONEXCLUSIVE flag is deprecated and users should
rely on the GPIO shared proxy. All users of this codec driver are ARM64
and this architecture now enables automatically shared GPIOs for
everyone. The driver now longer has to care about the sharing so drop
the flag.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
 sound/soc/codecs/pcm3168a.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/sound/soc/codecs/pcm3168a.c b/sound/soc/codecs/pcm3168a.c
index 6f45ea4869a75d77344b06e1092aeedcea160058..c1a263216ea6d88757053e93d782b8c8c01f8d1e 100644
--- a/sound/soc/codecs/pcm3168a.c
+++ b/sound/soc/codecs/pcm3168a.c
@@ -725,16 +725,11 @@ int pcm3168a_probe(struct device *dev, struct regmap *regmap)
 	dev_set_drvdata(dev, pcm3168a);
 
 	/*
-	 * Request the reset (connected to RST pin) gpio line as non exclusive
-	 * as the same reset line might be connected to multiple pcm3168a codec
-	 *
 	 * The RST is low active, we want the GPIO line to be high initially, so
 	 * request the initial level to LOW which in practice means DEASSERTED:
 	 * The deasserted level of GPIO_ACTIVE_LOW is HIGH.
 	 */
-	pcm3168a->gpio_rst = devm_gpiod_get_optional(dev, "reset",
-						GPIOD_OUT_LOW |
-						GPIOD_FLAGS_BIT_NONEXCLUSIVE);
+	pcm3168a->gpio_rst = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
 	if (IS_ERR(pcm3168a->gpio_rst))
 		return dev_err_probe(dev, PTR_ERR(pcm3168a->gpio_rst),
 				     "failed to acquire RST gpio\n");

---
base-commit: 2637bdec0535a2044cd830eba9a79363651d9043
change-id: 20261103-pcm3168a-non-exclusive-gpios-10918c1070f2

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

Re: [PATCH] ASoC: pcm3168a: don't request the reset GPIO as non-exclusive

[Mark Brown]

> The GPIOD_FLAGS_BIT_NONEXCLUSIVE flag is deprecated and users should
> rely on the GPIO shared proxy. All users of this codec driver are ARM64
> and this architecture now enables automatically shared GPIOs for
> everyone. The driver now longer has to care about the sharing so drop
> the flag.

sound/soc/intel/avs/boards/pcm3168a.c would beg to differ about this
being arm64 only, though that only has one CODEC and shouldn't share the
GPIO so it should be fine.

-- 
Mark Brown <broonie@kernel.org>

Re: [PATCH] ASoC: pcm3168a: don't request the reset GPIO as non-exclusive

[Bartosz Golaszewski]

On Wed, Nov 04, 2026 at 12:03:55AM +0000, Mark Brown wrote:
> > The GPIOD_FLAGS_BIT_NONEXCLUSIVE flag is deprecated and users should
> > rely on the GPIO shared proxy. All users of this codec driver are ARM64
> > and this architecture now enables automatically shared GPIOs for
> > everyone. The driver now longer has to care about the sharing so drop
> > the flag.
> 
> sound/soc/intel/avs/boards/pcm3168a.c would beg to differ about this
> being arm64 only, though that only has one CODEC and shouldn't share the
> GPIO so it should be fine.
>

Right. Do you want me to resend with commit message amended?

Bart

Re: [PATCH] ASoC: pcm3168a: don't request the reset GPIO as non-exclusive

[Cezary Rojewski]

On 11/4/2026 9:06 AM, Bartosz Golaszewski wrote:
> On Wed, Nov 04, 2026 at 12:03:55AM +0000, Mark Brown wrote:
>>> The GPIOD_FLAGS_BIT_NONEXCLUSIVE flag is deprecated and users should
>>> rely on the GPIO shared proxy. All users of this codec driver are ARM64
>>> and this architecture now enables automatically shared GPIOs for
>>> everyone. The driver now longer has to care about the sharing so drop
>>> the flag.
>>
>> sound/soc/intel/avs/boards/pcm3168a.c would beg to differ about this
>> being arm64 only, though that only has one CODEC and shouldn't share the
>> GPIO so it should be fine.
>>

Thank you, Mark, for mentioning this. Indeed, the x86 user (avs-driver)
does not utilize the GPIO but does utilize pcm3168a codec nonetheless.

> Right. Do you want me to resend with commit message amended?
While at it, two nitpicks:

ASoC: pcm3168a: -> ASoC: codecs: pcm3168a:
don't -> do not

(the last one simply makes the greps easier, and is more of a preference
thing).

Re: [PATCH] ASoC: pcm3168a: don't request the reset GPIO as non-exclusive

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

On Wed, Nov 04, 2026 at 09:06:31AM +0100, Bartosz Golaszewski wrote:
> On Wed, Nov 04, 2026 at 12:03:55AM +0000, Mark Brown wrote:

> > sound/soc/intel/avs/boards/pcm3168a.c would beg to differ about this
> > being arm64 only, though that only has one CODEC and shouldn't share the
> > GPIO so it should be fine.

> Right. Do you want me to resend with commit message amended?

May as well, especially with Cezary's other note.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]