From: Hans Zhang <18255117159@163.com>
To: Niklas Cassel <cassel@kernel.org>
Cc: manivannan.sadhasivam@linaro.org, kw@linux.com,
kishon@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
rockswang7@gmail.com
Subject: Re: [v8] misc: pci_endpoint_test: Fix overflow of bar_size
Date: Mon, 6 Jan 2025 21:56:07 +0800 [thread overview]
Message-ID: <9c40bcca-eee3-43b7-8b80-09a0efaa409f@163.com> (raw)
In-Reply-To: <Z3vDLcq9kWL4ueq7@ryzen>
On 2025/1/6 19:49, Niklas Cassel wrote:
>>
>> Signed-off-by: Hans Zhang <18255117159@163.com>
>> Reviewed-by: Niklas Cassel <cassel@kernel.org>
>> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> When significantly changing the patch from one version to another,
> (as in this case), you are supposed to drop the Reviewed-by tags.
Okay, i will remove the reviewer.
>
> Doing a:
> $ git grep -A 10 "IS_ENABLED(CONFIG_PHYS_ADDR_T_64BIT"
> does not show very many hits, which suggests that this is not the proper
> way to solve this.
>
> I don't know the proper solution to this. How is resource_size_t handled
> in other PCI driver when being built on with 32-bit PHYS_ADDR_T ?
>
> Can't you just cast the resource_size_t to u64 before doing the division?
>
Thank you Niklas. I'll try it.
Regards
Hans
next prev parent reply other threads:[~2025-01-06 13:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-04 15:16 Hans Zhang
2025-01-06 11:49 ` Niklas Cassel
2025-01-06 13:56 ` Hans Zhang [this message]
2025-01-06 15:32 ` Hans Zhang
2025-01-07 10:32 ` Niklas Cassel
2025-01-07 11:27 ` Hans Zhang
2025-01-07 11:33 ` Niklas Cassel
2025-01-07 11:43 ` Hans Zhang
2025-01-07 11:47 ` Niklas Cassel
2025-01-07 12:09 ` Hans Zhang
2025-01-07 13:36 ` Niklas Cassel
2025-01-07 15:44 ` Hans Zhang
2025-01-07 15:57 ` Niklas Cassel
2025-01-07 16:12 ` Hans Zhang
2025-01-08 14:10 ` Arnd Bergmann
2025-01-08 14:13 ` Niklas Cassel
2025-01-09 2:59 ` Hans Zhang
2025-01-09 6:29 ` Arnd Bergmann
2025-01-09 9:19 ` Hans Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c40bcca-eee3-43b7-8b80-09a0efaa409f@163.com \
--to=18255117159@163.com \
--cc=arnd@arndb.de \
--cc=cassel@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=rockswang7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®