mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: shaozhengchao <shaozhengchao@huawei.com>
To: Matthieu Baerts <matthieu.baerts@tessares.net>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>, Shuah Khan <shuah@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	"David S. Miller" <davem@davemloft.net>,
	Paul Blakey <paulb@mellanox.com>,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	<mptcp@lists.linux.dev>
Cc: Pedro Tammela <pctammela@mojatatu.com>,
	Shuah Khan <skhan@linuxfoundation.org>,
	<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
	<linux-kselftest@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH net 3/3] selftests: tc: add ConnTrack procfs kconfig
Date: Fri, 14 Jul 2023 11:25:03 +0800	[thread overview]
Message-ID: <9c5a138d-e6f1-9085-d1a4-4b30334d2462@huawei.com> (raw)
In-Reply-To: <20230713-tc-selftests-lkft-v1-3-1eb4fd3a96e7@tessares.net>



On 2023/7/14 5:16, Matthieu Baerts wrote:
> When looking at the TC selftest reports, I noticed one test was failing
> because /proc/net/nf_conntrack was not available.
> 
>    not ok 373 3992 - Add ct action triggering DNAT tuple conflict
>    	Could not match regex pattern. Verify command output:
>    cat: /proc/net/nf_conntrack: No such file or directory
> 
> It is only available if NF_CONNTRACK_PROCFS kconfig is set. So the issue
> can be fixed simply by adding it to the list of required kconfig.
> 
> Fixes: e46905641316 ("tc-testing: add test for ct DNAT tuple collision")
> Cc: stable@vger.kernel.org
> Link: https://lore.kernel.org/netdev/0e061d4a-9a23-9f58-3b35-d8919de332d7@tessares.net/T/ [1]
> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
> ---
>   tools/testing/selftests/tc-testing/config | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/tc-testing/config b/tools/testing/selftests/tc-testing/config
> index d1ad29040c02..71706197ba0f 100644
> --- a/tools/testing/selftests/tc-testing/config
> +++ b/tools/testing/selftests/tc-testing/config
> @@ -5,6 +5,7 @@ CONFIG_NF_CONNTRACK=m
>   CONFIG_NF_CONNTRACK_MARK=y
>   CONFIG_NF_CONNTRACK_ZONES=y
>   CONFIG_NF_CONNTRACK_LABELS=y
> +CONFIG_NF_CONNTRACK_PROCFS=y
>   CONFIG_NF_FLOW_TABLE=m
>   CONFIG_NF_NAT=m
>   CONFIG_NETFILTER_XT_TARGET_LOG=m
> 

Tested-by: Zhengchao Shao <shaozhengchao@huawei.com>

  reply	other threads:[~2023-07-14  3:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-13 21:16 [PATCH net 0/3] selftests: tc: increase timeout and add missing kconfig Matthieu Baerts
2023-07-13 21:16 ` [PATCH net 1/3] selftests: tc: set timeout to 15 minutes Matthieu Baerts
2023-07-14  2:25   ` shaozhengchao
2023-07-14 17:49     ` Pedro Tammela
2023-07-17  8:32     ` Matthieu Baerts
2023-07-18  1:43       ` shaozhengchao
2023-07-13 21:16 ` [PATCH net 2/3] selftests: tc: add 'ct' action kconfig dep Matthieu Baerts
2023-07-14  2:56   ` shaozhengchao
2023-07-13 21:16 ` [PATCH net 3/3] selftests: tc: add ConnTrack procfs kconfig Matthieu Baerts
2023-07-14  3:25   ` shaozhengchao [this message]
2023-07-13 22:41 ` [PATCH net 0/3] selftests: tc: increase timeout and add missing kconfig Jamal Hadi Salim
2023-07-18  8:46 ` Matthieu Baerts
2023-07-19  0:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c5a138d-e6f1-9085-d1a4-4b30334d2462@huawei.com \
    --to=shaozhengchao@huawei.com \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=matthieu.baerts@tessares.net \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=paulb@mellanox.com \
    --cc=pctammela@mojatatu.com \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®