* [PATCH] staging: unisys: visornic: Update the description of 'poll_for_irq()'
@ 2019-07-21 17:08 Christophe JAILLET
2019-07-22 6:57 ` Enrico Weigelt, metux IT consult
2019-07-22 6:57 ` Enrico Weigelt, metux IT consult
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2019-07-21 17:08 UTC (permalink / raw)
To: david.kershner, gregkh, hariprasad.kelam, petrm, davem, jannh
Cc: sparmaintainer, devel, linux-kernel, kernel-janitors, Christophe JAILLET
Commit e99e88a9d2b06 ("treewide: setup_timer() -> timer_setup()") has
updated the parameters of 'poll_for_irq()' but not the comment above the
function.
Update the comment and fix a typo.
s/visronic/visornic/
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/staging/unisys/visornic/visornic_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c
index 9d4f1dab0968..40dd573e73c3 100644
--- a/drivers/staging/unisys/visornic/visornic_main.c
+++ b/drivers/staging/unisys/visornic/visornic_main.c
@@ -1750,7 +1750,8 @@ static int visornic_poll(struct napi_struct *napi, int budget)
}
/* poll_for_irq - checks the status of the response queue
- * @v: Void pointer to the visronic devdata struct.
+ * @t: pointer to the 'struct timer_list' from which we can retrieve the
+ * the visornic devdata struct.
*
* Main function of the vnic_incoming thread. Periodically check the response
* queue and drain it if needed.
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: unisys: visornic: Update the description of 'poll_for_irq()'
2019-07-21 17:08 [PATCH] staging: unisys: visornic: Update the description of 'poll_for_irq()' Christophe JAILLET
@ 2019-07-22 6:57 ` Enrico Weigelt, metux IT consult
2019-07-22 6:57 ` Enrico Weigelt, metux IT consult
1 sibling, 0 replies; 3+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-07-22 6:57 UTC (permalink / raw)
To: Christophe JAILLET, david.kershner, gregkh, hariprasad.kelam,
petrm, davem, jannh
Cc: sparmaintainer, devel, linux-kernel, kernel-janitors
On 21.07.19 19:08, Christophe JAILLET wrote:
> Commit e99e88a9d2b06 ("treewide: setup_timer() -> timer_setup()") has
> updated the parameters of 'poll_for_irq()' but not the comment above the
> function.
>
> Update the comment and fix a typo.
> s/visronic/visornic/
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/staging/unisys/visornic/visornic_main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c
> index 9d4f1dab0968..40dd573e73c3 100644
> --- a/drivers/staging/unisys/visornic/visornic_main.c
> +++ b/drivers/staging/unisys/visornic/visornic_main.c
> @@ -1750,7 +1750,8 @@ static int visornic_poll(struct napi_struct *napi, int budget)
> }
>
> /* poll_for_irq - checks the status of the response queue
> - * @v: Void pointer to the visronic devdata struct.
> + * @t: pointer to the 'struct timer_list' from which we can retrieve the
> + * the visornic devdata struct.
> *
> * Main function of the vnic_incoming thread. Periodically check the response
> * queue and drain it if needed.
>
Reviewed-By: Enrico Weigelt <info@metux.net>
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: unisys: visornic: Update the description of 'poll_for_irq()'
2019-07-21 17:08 [PATCH] staging: unisys: visornic: Update the description of 'poll_for_irq()' Christophe JAILLET
2019-07-22 6:57 ` Enrico Weigelt, metux IT consult
@ 2019-07-22 6:57 ` Enrico Weigelt, metux IT consult
1 sibling, 0 replies; 3+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-07-22 6:57 UTC (permalink / raw)
To: Christophe JAILLET, david.kershner, gregkh, hariprasad.kelam,
petrm, davem, jannh
Cc: sparmaintainer, devel, linux-kernel, kernel-janitors
On 21.07.19 19:08, Christophe JAILLET wrote:
> Commit e99e88a9d2b06 ("treewide: setup_timer() -> timer_setup()") has
> updated the parameters of 'poll_for_irq()' but not the comment above the
> function.
>
> Update the comment and fix a typo.
> s/visronic/visornic/
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/staging/unisys/visornic/visornic_main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c
> index 9d4f1dab0968..40dd573e73c3 100644
> --- a/drivers/staging/unisys/visornic/visornic_main.c
> +++ b/drivers/staging/unisys/visornic/visornic_main.c
> @@ -1750,7 +1750,8 @@ static int visornic_poll(struct napi_struct *napi, int budget)
> }
>
> /* poll_for_irq - checks the status of the response queue
> - * @v: Void pointer to the visronic devdata struct.
> + * @t: pointer to the 'struct timer_list' from which we can retrieve the
> + * the visornic devdata struct.
> *
> * Main function of the vnic_incoming thread. Periodically check the response
> * queue and drain it if needed.
>
Reviewed-By: Enrico Weigelt <info@metux.net>
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-22 6:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-21 17:08 [PATCH] staging: unisys: visornic: Update the description of 'poll_for_irq()' Christophe JAILLET
2019-07-22 6:57 ` Enrico Weigelt, metux IT consult
2019-07-22 6:57 ` Enrico Weigelt, metux IT consult
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®