mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Waiman Long <longman@redhat.com>
To: Davidlohr Bueso <dave@stgolabs.net>,
	peterz@infradead.org, mingo@redhat.com
Cc: will@kernel.org, linux-kernel@vger.kernel.org,
	Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH -tip] locking: Move CONFIG_LOCK_EVENT_COUNTS into Kernel hacking section
Date: Mon, 29 Mar 2021 22:13:14 -0400	[thread overview]
Message-ID: <9c703d99-c08c-ad9d-e60d-d786737cfd6f@redhat.com> (raw)
In-Reply-To: <20210330020636.112594-1-dave@stgolabs.net>

On 3/29/21 10:06 PM, Davidlohr Bueso wrote:
> It's a lot more intuitive to have it in the locking section of the kernel
> hacking part rather than under "General architecture-dependent options".
>
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
> ---
>   arch/Kconfig      | 9 ---------
>   lib/Kconfig.debug | 9 +++++++++
>   2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/Kconfig b/arch/Kconfig
> index ecfd3520b676..d6f9aeaaf9f2 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -1113,15 +1113,6 @@ config HAVE_ARCH_PREL32_RELOCATIONS
>   config ARCH_USE_MEMREMAP_PROT
>   	bool
>   
> -config LOCK_EVENT_COUNTS
> -	bool "Locking event counts collection"
> -	depends on DEBUG_FS
> -	help
> -	  Enable light-weight counting of various locking related events
> -	  in the system with minimal performance impact. This reduces
> -	  the chance of application behavior change because of timing
> -	  differences. The counts are reported via debugfs.
> -
>   # Select if the architecture has support for applying RELR relocations.
>   config ARCH_HAS_RELR
>   	bool
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 2779c29d9981..76639ff5998c 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1401,6 +1401,15 @@ config DEBUG_LOCKING_API_SELFTESTS
>   	  The following locking APIs are covered: spinlocks, rwlocks,
>   	  mutexes and rwsems.
>   
> +config LOCK_EVENT_COUNTS
> +	bool "Locking event counts collection"
> +	depends on DEBUG_FS
> +	help
> +	  Enable light-weight counting of various locking related events
> +	  in the system with minimal performance impact. This reduces
> +	  the chance of application behavior change because of timing
> +	  differences. The counts are reported via debugfs.
> +
>   config LOCK_TORTURE_TEST
>   	tristate "torture tests for locking"
>   	depends on DEBUG_KERNEL

It looks good to me.

Acked-by: Waiman Long <longman@redhat.com>


  reply	other threads:[~2021-03-30  2:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-30  2:06 Davidlohr Bueso
2021-03-30  2:13 ` Waiman Long [this message]
2021-08-12 19:05 ` Davidlohr Bueso
2021-08-12 19:42   ` Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c703d99-c08c-ad9d-e60d-d786737cfd6f@redhat.com \
    --to=longman@redhat.com \
    --cc=dave@stgolabs.net \
    --cc=dbueso@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®