* [PATCH -tip] locking: Move CONFIG_LOCK_EVENT_COUNTS into Kernel hacking section
@ 2021-03-30 2:06 Davidlohr Bueso
2021-03-30 2:13 ` Waiman Long
2021-08-12 19:05 ` Davidlohr Bueso
0 siblings, 2 replies; 4+ messages in thread
From: Davidlohr Bueso @ 2021-03-30 2:06 UTC (permalink / raw)
To: peterz, mingo; +Cc: longman, will, linux-kernel, dave, Davidlohr Bueso
It's a lot more intuitive to have it in the locking section of the kernel
hacking part rather than under "General architecture-dependent options".
Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
---
arch/Kconfig | 9 ---------
lib/Kconfig.debug | 9 +++++++++
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/Kconfig b/arch/Kconfig
index ecfd3520b676..d6f9aeaaf9f2 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -1113,15 +1113,6 @@ config HAVE_ARCH_PREL32_RELOCATIONS
config ARCH_USE_MEMREMAP_PROT
bool
-config LOCK_EVENT_COUNTS
- bool "Locking event counts collection"
- depends on DEBUG_FS
- help
- Enable light-weight counting of various locking related events
- in the system with minimal performance impact. This reduces
- the chance of application behavior change because of timing
- differences. The counts are reported via debugfs.
-
# Select if the architecture has support for applying RELR relocations.
config ARCH_HAS_RELR
bool
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 2779c29d9981..76639ff5998c 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1401,6 +1401,15 @@ config DEBUG_LOCKING_API_SELFTESTS
The following locking APIs are covered: spinlocks, rwlocks,
mutexes and rwsems.
+config LOCK_EVENT_COUNTS
+ bool "Locking event counts collection"
+ depends on DEBUG_FS
+ help
+ Enable light-weight counting of various locking related events
+ in the system with minimal performance impact. This reduces
+ the chance of application behavior change because of timing
+ differences. The counts are reported via debugfs.
+
config LOCK_TORTURE_TEST
tristate "torture tests for locking"
depends on DEBUG_KERNEL
--
2.26.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -tip] locking: Move CONFIG_LOCK_EVENT_COUNTS into Kernel hacking section
2021-03-30 2:06 [PATCH -tip] locking: Move CONFIG_LOCK_EVENT_COUNTS into Kernel hacking section Davidlohr Bueso
@ 2021-03-30 2:13 ` Waiman Long
2021-08-12 19:05 ` Davidlohr Bueso
1 sibling, 0 replies; 4+ messages in thread
From: Waiman Long @ 2021-03-30 2:13 UTC (permalink / raw)
To: Davidlohr Bueso, peterz, mingo; +Cc: will, linux-kernel, Davidlohr Bueso
On 3/29/21 10:06 PM, Davidlohr Bueso wrote:
> It's a lot more intuitive to have it in the locking section of the kernel
> hacking part rather than under "General architecture-dependent options".
>
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
> ---
> arch/Kconfig | 9 ---------
> lib/Kconfig.debug | 9 +++++++++
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/Kconfig b/arch/Kconfig
> index ecfd3520b676..d6f9aeaaf9f2 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -1113,15 +1113,6 @@ config HAVE_ARCH_PREL32_RELOCATIONS
> config ARCH_USE_MEMREMAP_PROT
> bool
>
> -config LOCK_EVENT_COUNTS
> - bool "Locking event counts collection"
> - depends on DEBUG_FS
> - help
> - Enable light-weight counting of various locking related events
> - in the system with minimal performance impact. This reduces
> - the chance of application behavior change because of timing
> - differences. The counts are reported via debugfs.
> -
> # Select if the architecture has support for applying RELR relocations.
> config ARCH_HAS_RELR
> bool
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 2779c29d9981..76639ff5998c 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1401,6 +1401,15 @@ config DEBUG_LOCKING_API_SELFTESTS
> The following locking APIs are covered: spinlocks, rwlocks,
> mutexes and rwsems.
>
> +config LOCK_EVENT_COUNTS
> + bool "Locking event counts collection"
> + depends on DEBUG_FS
> + help
> + Enable light-weight counting of various locking related events
> + in the system with minimal performance impact. This reduces
> + the chance of application behavior change because of timing
> + differences. The counts are reported via debugfs.
> +
> config LOCK_TORTURE_TEST
> tristate "torture tests for locking"
> depends on DEBUG_KERNEL
It looks good to me.
Acked-by: Waiman Long <longman@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -tip] locking: Move CONFIG_LOCK_EVENT_COUNTS into Kernel hacking section
2021-03-30 2:06 [PATCH -tip] locking: Move CONFIG_LOCK_EVENT_COUNTS into Kernel hacking section Davidlohr Bueso
2021-03-30 2:13 ` Waiman Long
@ 2021-08-12 19:05 ` Davidlohr Bueso
2021-08-12 19:42 ` Waiman Long
1 sibling, 1 reply; 4+ messages in thread
From: Davidlohr Bueso @ 2021-08-12 19:05 UTC (permalink / raw)
To: peterz, mingo; +Cc: longman, will, linux-kernel, Davidlohr Bueso
Ping?
On Mon, 29 Mar 2021, Davidlohr Bueso wrote:
>It's a lot more intuitive to have it in the locking section of the kernel
>hacking part rather than under "General architecture-dependent options".
>
>Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
>---
> arch/Kconfig | 9 ---------
> lib/Kconfig.debug | 9 +++++++++
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
>diff --git a/arch/Kconfig b/arch/Kconfig
>index ecfd3520b676..d6f9aeaaf9f2 100644
>--- a/arch/Kconfig
>+++ b/arch/Kconfig
>@@ -1113,15 +1113,6 @@ config HAVE_ARCH_PREL32_RELOCATIONS
> config ARCH_USE_MEMREMAP_PROT
> bool
>
>-config LOCK_EVENT_COUNTS
>- bool "Locking event counts collection"
>- depends on DEBUG_FS
>- help
>- Enable light-weight counting of various locking related events
>- in the system with minimal performance impact. This reduces
>- the chance of application behavior change because of timing
>- differences. The counts are reported via debugfs.
>-
> # Select if the architecture has support for applying RELR relocations.
> config ARCH_HAS_RELR
> bool
>diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
>index 2779c29d9981..76639ff5998c 100644
>--- a/lib/Kconfig.debug
>+++ b/lib/Kconfig.debug
>@@ -1401,6 +1401,15 @@ config DEBUG_LOCKING_API_SELFTESTS
> The following locking APIs are covered: spinlocks, rwlocks,
> mutexes and rwsems.
>
>+config LOCK_EVENT_COUNTS
>+ bool "Locking event counts collection"
>+ depends on DEBUG_FS
>+ help
>+ Enable light-weight counting of various locking related events
>+ in the system with minimal performance impact. This reduces
>+ the chance of application behavior change because of timing
>+ differences. The counts are reported via debugfs.
>+
> config LOCK_TORTURE_TEST
> tristate "torture tests for locking"
> depends on DEBUG_KERNEL
>--
>2.26.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -tip] locking: Move CONFIG_LOCK_EVENT_COUNTS into Kernel hacking section
2021-08-12 19:05 ` Davidlohr Bueso
@ 2021-08-12 19:42 ` Waiman Long
0 siblings, 0 replies; 4+ messages in thread
From: Waiman Long @ 2021-08-12 19:42 UTC (permalink / raw)
To: Davidlohr Bueso, peterz, mingo; +Cc: will, linux-kernel, Davidlohr Bueso
On 8/12/21 3:05 PM, Davidlohr Bueso wrote:
> Ping?
>
> On Mon, 29 Mar 2021, Davidlohr Bueso wrote:
>
>> It's a lot more intuitive to have it in the locking section of the
>> kernel
>> hacking part rather than under "General architecture-dependent options".
>>
>> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
>> ---
>> arch/Kconfig | 9 ---------
>> lib/Kconfig.debug | 9 +++++++++
>> 2 files changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/arch/Kconfig b/arch/Kconfig
>> index ecfd3520b676..d6f9aeaaf9f2 100644
>> --- a/arch/Kconfig
>> +++ b/arch/Kconfig
>> @@ -1113,15 +1113,6 @@ config HAVE_ARCH_PREL32_RELOCATIONS
>> config ARCH_USE_MEMREMAP_PROT
>> bool
>>
>> -config LOCK_EVENT_COUNTS
>> - bool "Locking event counts collection"
>> - depends on DEBUG_FS
>> - help
>> - Enable light-weight counting of various locking related events
>> - in the system with minimal performance impact. This reduces
>> - the chance of application behavior change because of timing
>> - differences. The counts are reported via debugfs.
>> -
>> # Select if the architecture has support for applying RELR relocations.
>> config ARCH_HAS_RELR
>> bool
>> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
>> index 2779c29d9981..76639ff5998c 100644
>> --- a/lib/Kconfig.debug
>> +++ b/lib/Kconfig.debug
>> @@ -1401,6 +1401,15 @@ config DEBUG_LOCKING_API_SELFTESTS
>> The following locking APIs are covered: spinlocks, rwlocks,
>> mutexes and rwsems.
>>
>> +config LOCK_EVENT_COUNTS
>> + bool "Locking event counts collection"
>> + depends on DEBUG_FS
>> + help
>> + Enable light-weight counting of various locking related events
>> + in the system with minimal performance impact. This reduces
>> + the chance of application behavior change because of timing
>> + differences. The counts are reported via debugfs.
>> +
>> config LOCK_TORTURE_TEST
>> tristate "torture tests for locking"
>> depends on DEBUG_KERNEL
>> --
>> 2.26.2
>>
>
I have no objection to that.
Acked-by: Waiman Long <longman@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-12 19:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-30 2:06 [PATCH -tip] locking: Move CONFIG_LOCK_EVENT_COUNTS into Kernel hacking section Davidlohr Bueso
2021-03-30 2:13 ` Waiman Long
2021-08-12 19:05 ` Davidlohr Bueso
2021-08-12 19:42 ` Waiman Long
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®