From: Markus Elfring <Markus.Elfring@web.de>
To: Yongzhi Liu <hyperlyzcs@gmail.com>,
GR-QLogic-Storage-Upstream@marvell.com,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
James Bottomley <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Nilesh Javali <njavali@marvell.com>,
Saurav Kashyap <skashyap@marvell.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Himanshu Madhani <himanshu.madhani@oracle.com>,
huntazhang@tencent.com, jitxie@tencent.com
Subject: Re: [PATCH V2] scsi: qla2xxx: Fix double free of fcport in error handling path
Date: Mon, 29 Apr 2024 07:12:17 +0200 [thread overview]
Message-ID: <9c711441-6e79-422f-9405-ee271929e77c@web.de> (raw)
In-Reply-To: <20240428113404.12522-1-hyperlyzcs@gmail.com>
…> Fix this by cleaning up the redundant qla2x00_free_fcport() and
> replacing error handling with a goto chain.
I imagine that there can be a need to provide the desired software adjustment
as a patch series with two separate update steps.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n81
* Deletion of inappropriate function calls
* Optimisation of exception handling
How do you think about to refer to the affected function
(instead of the hint “error handling path”) in the summary phrase?
Regards,
Markus
next prev parent reply other threads:[~2024-04-29 5:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 9:37 [PATCH] " Yongzhi Liu
2024-04-25 11:31 ` Markus Elfring
2024-04-28 11:34 ` [PATCH V2] " Yongzhi Liu
2024-04-28 12:52 ` Markus Elfring
2024-04-29 5:12 ` Markus Elfring [this message]
2024-04-30 9:11 ` [PATCH V3 1/2] scsi: qla2xxx: Fix double free of fcport in qla24xx_els_dcmd_iocb Yongzhi Liu
2024-04-30 9:11 ` [PATCH V3 2/2] scsi: qla2xxx: Optimisation of exception handling " Yongzhi Liu
2024-04-30 11:21 ` Markus Elfring
2024-05-06 12:38 ` [PATCH V4 0/2] Bugfix and optimisation of exception handling Yongzhi Liu
2024-05-06 12:38 ` [PATCH V4 1/2] scsi: qla2xxx: Fix double free of fcport in qla24xx_els_dcmd_iocb() Yongzhi Liu
2024-05-06 12:38 ` [PATCH V4 2/2] scsi: qla2xxx: Use common error handling code " Yongzhi Liu
2024-04-30 9:55 ` [PATCH V3 1/2] scsi: qla2xxx: Fix double free of fcport in qla24xx_els_dcmd_iocb Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c711441-6e79-422f-9405-ee271929e77c@web.de \
--to=markus.elfring@web.de \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=himanshu.madhani@oracle.com \
--cc=huntazhang@tencent.com \
--cc=hyperlyzcs@gmail.com \
--cc=jitxie@tencent.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=njavali@marvell.com \
--cc=skashyap@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®