mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Bogdan Nicolae <bogdan.nicolae@gmail.com>
Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
	brcm80211-dev-list.pdl@broadcom.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] wifi: brcmfmac: cyw: set a unique cookie for mgmt tx
Date: Sun, 26 Jul 2026 21:20:52 +0200	[thread overview]
Message-ID: <9ca181db-7bec-4f6c-9f42-4a66068af354@broadcom.com> (raw)
In-Reply-To: <20260725014411.170340-1-bogdan.nicolae@gmail.com>

On 25/07/2026 03:44, Bogdan Nicolae wrote:
> Set cookie using an increasing atomic counter. Avoids mismatches of completion
> events later in brcmf_notify_mgmt_tx_status, where packet_id != vif->mgmt_tx_id
> is checked.

Thanks for the split. I increased the scope and been looking in the 
cookie usage in the wireless subsystem. So I have a series lined up to 
change the cookie to an input parameter and have cfg80211 hand out the 
cookie value (it already has cfg80211_assign_cookie() function). This
will also cover zero cookie fix here. So I would suggest to drop this 
patch and only let the PMKID patch go in.

Regards,
Arend

  reply	other threads:[~2026-07-26 19:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-25  1:44 Bogdan Nicolae
2026-07-26 19:20 ` Arend van Spriel [this message]
2026-07-26 19:21   ` Bogdan Nicolae
2026-08-02  8:39 ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ca181db-7bec-4f6c-9f42-4a66068af354@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=bogdan.nicolae@gmail.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®