* [PATCH v1] drm/virtio: Fix type of dma-fence context variable
@ 2024-07-14 20:50 Dmitry Osipenko
2024-07-23 0:21 ` Rob Clark
2024-07-24 17:45 ` Dmitry Osipenko
0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Osipenko @ 2024-07-14 20:50 UTC (permalink / raw)
To: David Airlie, Gerd Hoffmann, Gurchetan Singh, Chia-I Wu,
Rob Clark, Pierre-Eric Pelloux-Prayer
Cc: dri-devel, linux-kernel, kernel
Type of DMA fence context is u64. Fence-waiting code uses u32 for the
context variable, fix it.
Fixes: e4812ab8e6b1 ("drm/virtio: Refactor and optimize job submission code path")
Cc: <stable@vger.kernel.org> # v6.4+
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
drivers/gpu/drm/virtio/virtgpu_submit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_submit.c b/drivers/gpu/drm/virtio/virtgpu_submit.c
index 1c7c7f61a222..7d34cf83f5f2 100644
--- a/drivers/gpu/drm/virtio/virtgpu_submit.c
+++ b/drivers/gpu/drm/virtio/virtgpu_submit.c
@@ -48,7 +48,7 @@ struct virtio_gpu_submit {
static int virtio_gpu_do_fence_wait(struct virtio_gpu_submit *submit,
struct dma_fence *in_fence)
{
- u32 context = submit->fence_ctx + submit->ring_idx;
+ u64 context = submit->fence_ctx + submit->ring_idx;
if (dma_fence_match_context(in_fence, context))
return 0;
--
2.45.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] drm/virtio: Fix type of dma-fence context variable
2024-07-14 20:50 [PATCH v1] drm/virtio: Fix type of dma-fence context variable Dmitry Osipenko
@ 2024-07-23 0:21 ` Rob Clark
2024-07-24 17:45 ` Dmitry Osipenko
1 sibling, 0 replies; 3+ messages in thread
From: Rob Clark @ 2024-07-23 0:21 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: David Airlie, Gerd Hoffmann, Gurchetan Singh, Chia-I Wu,
Pierre-Eric Pelloux-Prayer, dri-devel, linux-kernel, kernel
On Sun, Jul 14, 2024 at 1:50 PM Dmitry Osipenko
<dmitry.osipenko@collabora.com> wrote:
>
> Type of DMA fence context is u64. Fence-waiting code uses u32 for the
> context variable, fix it.
>
> Fixes: e4812ab8e6b1 ("drm/virtio: Refactor and optimize job submission code path")
> Cc: <stable@vger.kernel.org> # v6.4+
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Reviewed-by: Rob Clark <robdclark@gmail.com>
> ---
> drivers/gpu/drm/virtio/virtgpu_submit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_submit.c b/drivers/gpu/drm/virtio/virtgpu_submit.c
> index 1c7c7f61a222..7d34cf83f5f2 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_submit.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_submit.c
> @@ -48,7 +48,7 @@ struct virtio_gpu_submit {
> static int virtio_gpu_do_fence_wait(struct virtio_gpu_submit *submit,
> struct dma_fence *in_fence)
> {
> - u32 context = submit->fence_ctx + submit->ring_idx;
> + u64 context = submit->fence_ctx + submit->ring_idx;
>
> if (dma_fence_match_context(in_fence, context))
> return 0;
> --
> 2.45.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] drm/virtio: Fix type of dma-fence context variable
2024-07-14 20:50 [PATCH v1] drm/virtio: Fix type of dma-fence context variable Dmitry Osipenko
2024-07-23 0:21 ` Rob Clark
@ 2024-07-24 17:45 ` Dmitry Osipenko
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Osipenko @ 2024-07-24 17:45 UTC (permalink / raw)
To: David Airlie, Gerd Hoffmann, Gurchetan Singh, Chia-I Wu,
Rob Clark, Pierre-Eric Pelloux-Prayer
Cc: dri-devel, linux-kernel, kernel
On 7/14/24 23:50, Dmitry Osipenko wrote:
> Type of DMA fence context is u64. Fence-waiting code uses u32 for the
> context variable, fix it.
>
> Fixes: e4812ab8e6b1 ("drm/virtio: Refactor and optimize job submission code path")
> Cc: <stable@vger.kernel.org> # v6.4+
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> ---
> drivers/gpu/drm/virtio/virtgpu_submit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_submit.c b/drivers/gpu/drm/virtio/virtgpu_submit.c
> index 1c7c7f61a222..7d34cf83f5f2 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_submit.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_submit.c
> @@ -48,7 +48,7 @@ struct virtio_gpu_submit {
> static int virtio_gpu_do_fence_wait(struct virtio_gpu_submit *submit,
> struct dma_fence *in_fence)
> {
> - u32 context = submit->fence_ctx + submit->ring_idx;
> + u64 context = submit->fence_ctx + submit->ring_idx;
>
> if (dma_fence_match_context(in_fence, context))
> return 0;
Applied to misc-fixes
--
Best regards,
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-24 17:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-14 20:50 [PATCH v1] drm/virtio: Fix type of dma-fence context variable Dmitry Osipenko
2024-07-23 0:21 ` Rob Clark
2024-07-24 17:45 ` Dmitry Osipenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®