* [PATCH] bcachefs: Remove duplicate included headers
@ 2024-08-29 15:49 Thorsten Blum
2024-08-30 1:26 ` Hongbo Li
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2024-08-29 15:49 UTC (permalink / raw)
To: kent.overstreet; +Cc: linux-bcachefs, linux-kernel, Thorsten Blum
The header files dirent_format.h and disk_groups_format.h are included
twice. Remove the redundant includes and the following warnings reported
by make includecheck:
disk_groups_format.h is included more than once
dirent_format.h is included more than once
Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
---
fs/bcachefs/bcachefs_format.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/bcachefs/bcachefs_format.h b/fs/bcachefs/bcachefs_format.h
index 14ce726bf5a3..b97fd0f75831 100644
--- a/fs/bcachefs/bcachefs_format.h
+++ b/fs/bcachefs/bcachefs_format.h
@@ -499,8 +499,6 @@ struct bch_sb_field {
#include "disk_groups_format.h"
#include "extents_format.h"
#include "ec_format.h"
-#include "dirent_format.h"
-#include "disk_groups_format.h"
#include "inode_format.h"
#include "journal_seq_blacklist_format.h"
#include "logged_ops_format.h"
--
2.46.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] bcachefs: Remove duplicate included headers
2024-08-29 15:49 [PATCH] bcachefs: Remove duplicate included headers Thorsten Blum
@ 2024-08-30 1:26 ` Hongbo Li
0 siblings, 0 replies; 2+ messages in thread
From: Hongbo Li @ 2024-08-30 1:26 UTC (permalink / raw)
To: Thorsten Blum, kent.overstreet; +Cc: linux-bcachefs, linux-kernel
On 2024/8/29 23:49, Thorsten Blum wrote:
> The header files dirent_format.h and disk_groups_format.h are included
> twice. Remove the redundant includes and the following warnings reported
> by make includecheck:
>
> disk_groups_format.h is included more than once
> dirent_format.h is included more than once
>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
> ---
> fs/bcachefs/bcachefs_format.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/bcachefs/bcachefs_format.h b/fs/bcachefs/bcachefs_format.h
> index 14ce726bf5a3..b97fd0f75831 100644
> --- a/fs/bcachefs/bcachefs_format.h
> +++ b/fs/bcachefs/bcachefs_format.h
> @@ -499,8 +499,6 @@ struct bch_sb_field {
> #include "disk_groups_format.h"
> #include "extents_format.h"
> #include "ec_format.h"
> -#include "dirent_format.h"
> -#include "disk_groups_format.h"
line 497 and line 499.
Reviewed-by: Hongbo Li <lihongbo22@huawei.com>
> #include "inode_format.h"
> #include "journal_seq_blacklist_format.h"
> #include "logged_ops_format.h"
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-30 1:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-29 15:49 [PATCH] bcachefs: Remove duplicate included headers Thorsten Blum
2024-08-30 1:26 ` Hongbo Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®