From: Markus Elfring <Markus.Elfring@web.de>
To: Zilin Guan <zilin@seu.edu.cn>,
linux-scsi@vger.kernel.org, Don Brace <don.brace@microchip.com>
Cc: storagedev@microchip.com, LKML <linux-kernel@vger.kernel.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Jianhao Xu <jianhao.xu@seu.edu.cn>,
John Donnelly <john.p.donnelly@oracle.com>,
Mike McGowen <mike.mcgowen@microchip.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Scott Benesh <scott.benesh@microchip.com>,
Scott Teel <scott.teel@microchip.com>
Subject: Re: [PATCH] scsi: smartpqi: fix memory leak in pqi_report_phys_luns()
Date: Sat, 31 Jan 2026 20:18:09 +0100 [thread overview]
Message-ID: <9d0292db-1498-405b-9b30-1e0295d893ab@web.de> (raw)
In-Reply-To: <20260131093641.1008117-1-zilin@seu.edu.cn>
…
> Fixes: 28ca6d876c5a ("scsi: smartpqi: Add extended report physical LUNs")
…
See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v6.19-rc7#n34
…
> +++ b/drivers/scsi/smartpqi/smartpqi_init.c
…
> @@ -1275,6 +1278,10 @@ static inline int pqi_report_phys_luns(struct pqi_ctrl_info *ctrl_info, void **b
> *buffer = rpl_16byte_wwid_list;
>
> return 0;
> +
> +out_free_rpl_list:
> + kfree(rpl_list);
> + return rc;
> }
…
* How do you think about to refer to the local variable “rpl_8byte_wwid_list” instead?
* Would you like to refine the control flow a bit more for the end
of this function implementation?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.19-rc7#n526
Regards,
Markus
next prev parent reply other threads:[~2026-01-31 19:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 9:36 Zilin Guan
2026-01-31 19:18 ` Markus Elfring [this message]
2026-02-03 19:54 ` Don.Brace
2026-02-04 3:24 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d0292db-1498-405b-9b30-1e0295d893ab@web.de \
--to=markus.elfring@web.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=don.brace@microchip.com \
--cc=jianhao.xu@seu.edu.cn \
--cc=john.p.donnelly@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mike.mcgowen@microchip.com \
--cc=scott.benesh@microchip.com \
--cc=scott.teel@microchip.com \
--cc=storagedev@microchip.com \
--cc=zilin@seu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®