From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Zilin Guan <zilin@seu.edu.cn>
Cc: don.brace@microchip.com, James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, scott.teel@microchip.com,
john.p.donnelly@oracle.com, scott.benesh@microchip.com,
Mike.McGowen@microchip.com, storagedev@microchip.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
jianhao.xu@seu.edu.cn
Subject: Re: [PATCH] scsi: smartpqi: fix memory leak in pqi_report_phys_luns()
Date: Tue, 03 Feb 2026 22:24:13 -0500 [thread overview]
Message-ID: <yq1pl6lnqdd.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20260131093641.1008117-1-zilin@seu.edu.cn> (Zilin Guan's message of "Sat, 31 Jan 2026 09:36:41 +0000")
Zilin,
> pqi_report_phys_luns() fails to release the rpl_list buffer when
> encountering an unsupported data format or when the allocation for
> rpl_16byte_wwid_list fails. These early returns bypass the cleanup
> logic, leading to memory leaks.
Applied to 6.20/scsi-staging, thanks!
--
Martin K. Petersen
prev parent reply other threads:[~2026-02-04 3:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 9:36 Zilin Guan
2026-01-31 19:18 ` Markus Elfring
2026-02-03 19:54 ` Don.Brace
2026-02-04 3:24 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1pl6lnqdd.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Mike.McGowen@microchip.com \
--cc=don.brace@microchip.com \
--cc=jianhao.xu@seu.edu.cn \
--cc=john.p.donnelly@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=scott.benesh@microchip.com \
--cc=scott.teel@microchip.com \
--cc=storagedev@microchip.com \
--cc=zilin@seu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®