From: Bibek Kumar Patro <quic_bibekkum@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <will@kernel.org>,
<robin.murphy@arm.com>, <joro@8bytes.org>,
<dmitry.baryshkov@linaro.org>, <jsnitsel@redhat.com>,
<quic_bjorande@quicinc.com>, <mani@kernel.org>,
<quic_eberman@quicinc.com>, <robdclark@chromium.org>,
<u.kleine-koenig@pengutronix.de>, <robh@kernel.org>,
<vladimir.oltean@nxp.com>, <quic_pkondeti@quicinc.com>,
<quic_molvera@quicinc.com>
Cc: <linux-arm-msm@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <iommu@lists.linux.dev>,
<linux-kernel@vger.kernel.org>,
<qipl.kernel.upstream@quicinc.com>
Subject: Re: [PATCH v7 4/5] iommu/arm-smmu: add ACTLR data and support for SM8550
Date: Wed, 10 Jan 2024 17:05:14 +0530 [thread overview]
Message-ID: <9d143762-da25-4bdc-b33f-66a03a144c2e@quicinc.com> (raw)
In-Reply-To: <45314345-36ba-4d85-9d3b-298de26eb069@linaro.org>
On 1/10/2024 4:19 PM, Konrad Dybcio wrote:
>
>
> On 1/9/24 12:42, Bibek Kumar Patro wrote:
>> Add ACTLR data table for SM8550 along with support for
>> same including SM8550 specific implementation operations.
>>
>> Signed-off-by: Bibek Kumar Patro <quic_bibekkum@quicinc.com>
>> ---
> [...]
>
>> +static const struct actlr_variant sm8550_actlr[] = {
>> + { sm8550_apps_actlr_cfg, 0x15000000 },
>> + { sm8550_gfx_actlr_cfg, 0x03da0000 },
>> + {},
>> +};
>
> Please use C99 designated initializers and put the address first.
>
Noted, thanks for this input. Will take care of this in next patch.
Thanks & regards,
Bibek
> Konrad
next prev parent reply other threads:[~2024-01-10 11:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 11:42 [PATCH v7 0/5] iommu/arm-smmu: introduction of ACTLR implementation for Qualcomm SoCs Bibek Kumar Patro
2024-01-09 11:42 ` [PATCH v7 1/5] iommu/arm-smmu: re-enable context caching in smmu reset operation Bibek Kumar Patro
2024-01-10 11:00 ` Konrad Dybcio
2024-01-10 11:17 ` Bibek Kumar Patro
2024-01-09 11:42 ` [PATCH v7 2/5] iommu/arm-smmu: refactor qcom_smmu structure to include single pointer Bibek Kumar Patro
2024-01-09 11:42 ` [PATCH v7 3/5] iommu/arm-smmu: introduction of ACTLR for custom prefetcher settings Bibek Kumar Patro
2024-01-10 4:06 ` Pavan Kondeti
2024-01-10 11:16 ` Bibek Kumar Patro
2024-01-10 12:55 ` Bibek Kumar Patro
2024-01-10 17:56 ` Konrad Dybcio
2024-01-11 18:09 ` Bibek Kumar Patro
2024-01-12 10:01 ` Konrad Dybcio
2024-01-12 13:06 ` Bibek Kumar Patro
2024-01-12 13:14 ` Dmitry Baryshkov
2024-01-16 11:42 ` Bibek Kumar Patro
2024-01-09 11:42 ` [PATCH v7 4/5] iommu/arm-smmu: add ACTLR data and support for SM8550 Bibek Kumar Patro
2024-01-10 4:35 ` Pavan Kondeti
2024-01-10 10:49 ` Konrad Dybcio
2024-01-10 11:35 ` Bibek Kumar Patro [this message]
2024-01-09 11:42 ` [PATCH v7 5/5] iommu/arm-smmu: add ACTLR data and support for SC7280 Bibek Kumar Patro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d143762-da25-4bdc-b33f-66a03a144c2e@quicinc.com \
--to=quic_bibekkum@quicinc.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=jsnitsel@redhat.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=qipl.kernel.upstream@quicinc.com \
--cc=quic_bjorande@quicinc.com \
--cc=quic_eberman@quicinc.com \
--cc=quic_molvera@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=robdclark@chromium.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vladimir.oltean@nxp.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®