From: Milo Kim <woogyom.kim@gmail.com>
To: Andrzej Hajda <a.hajda@samsung.com>, David Airlie <airlied@linux.ie>
Cc: Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Seung-Woo Kim <sw0312.kim@samsung.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/4] gpu: drm: exynos_hdmi: Use consolidated function on binding DDC DT property
Date: Wed, 24 Aug 2016 16:21:28 +0900 [thread overview]
Message-ID: <9d5bf0cd-44f1-2028-7831-6828e43984d1@gmail.com> (raw)
In-Reply-To: <a6d2e6cc-d491-fdd4-8c76-5425ec42ba80@samsung.com>
Hi Andrzej,
On 08/24/2016 02:55 PM, Andrzej Hajda wrote:
> This is mistake introduced by other patch, of_node_put should be called on
> np, after calling of_find_i2c_adapter_by_node. You can fix it in your
> patch as well.
> I think you can move of_find_i2c_adapter_by_node also to this function and
> rename it to sth like hdmi_get_ddc_adapter, this way you will enclose
> whole logic
> of getting resource into one function.
Agree, let me prepare next patch-set. Thanks!
Best regards,
Milo
next prev parent reply other threads:[~2016-08-24 7:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 2:25 [PATCH v2 0/4] ARM: dts: exynos: Enable HDMI in Arndale Octa board Milo Kim
2016-08-24 2:25 ` [PATCH v2 1/4] ARM: dts: exynos: Enable HDMI for " Milo Kim
2016-08-24 5:28 ` Andrzej Hajda
2016-08-24 7:14 ` Milo Kim
2016-08-24 2:25 ` [PATCH v2 2/4] ARM: dts: exynos: Use 'hpd-gpios' instead of 'hpd-gpio' Milo Kim
2016-08-24 5:30 ` Andrzej Hajda
2016-08-24 2:25 ` [PATCH v2 3/4] gpu: drm: exynos_hdmi: Use consolidated function on binding DDC DT property Milo Kim
2016-08-24 5:55 ` Andrzej Hajda
2016-08-24 7:21 ` Milo Kim [this message]
2016-08-24 2:25 ` [PATCH v2 4/4] gpu: drm: exynos_hdmi: Use consolidated function on binding PHY " Milo Kim
2016-08-24 5:58 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d5bf0cd-44f1-2028-7831-6828e43984d1@gmail.com \
--to=woogyom.kim@gmail.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®