* [PATCH] drm/stm: Remove unnecessary .owner for lvds_platform_driver
@ 2024-07-01 6:23 Jiapeng Chong
2024-07-02 10:00 ` Raphael Gallais-Pou
2024-07-08 13:32 ` Philippe CORNU
0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Chong @ 2024-07-01 6:23 UTC (permalink / raw)
To: yannick.fertre
Cc: raphael.gallais-pou, philippe.cornu, maarten.lankhorst, mripard,
tzimmermann, airlied, daniel, mcoquelin.stm32, alexandre.torgue,
dri-devel, linux-stm32, linux-arm-kernel, linux-kernel,
Jiapeng Chong, Abaci Robot
Remove .owner field if calls are used which set it automatically.
./drivers/gpu/drm/stm/lvds.c:1213:3-8: No need to set .owner here. The core will do it.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9457
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/stm/lvds.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/stm/lvds.c b/drivers/gpu/drm/stm/lvds.c
index 2fa2c81784e9..06f2d7a56cc9 100644
--- a/drivers/gpu/drm/stm/lvds.c
+++ b/drivers/gpu/drm/stm/lvds.c
@@ -1210,7 +1210,6 @@ static struct platform_driver lvds_platform_driver = {
.remove = lvds_remove,
.driver = {
.name = "stm32-display-lvds",
- .owner = THIS_MODULE,
.of_match_table = lvds_dt_ids,
},
};
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/stm: Remove unnecessary .owner for lvds_platform_driver
2024-07-01 6:23 [PATCH] drm/stm: Remove unnecessary .owner for lvds_platform_driver Jiapeng Chong
@ 2024-07-02 10:00 ` Raphael Gallais-Pou
2024-07-08 13:32 ` Philippe CORNU
1 sibling, 0 replies; 3+ messages in thread
From: Raphael Gallais-Pou @ 2024-07-02 10:00 UTC (permalink / raw)
To: Jiapeng Chong, yannick.fertre
Cc: philippe.cornu, maarten.lankhorst, mripard, tzimmermann, airlied,
daniel, mcoquelin.stm32, alexandre.torgue, dri-devel,
linux-stm32, linux-arm-kernel, linux-kernel, Abaci Robot
Hi Jiapeng,
On 7/1/24 08:23, Jiapeng Chong wrote:
> Remove .owner field if calls are used which set it automatically.
>
> ./drivers/gpu/drm/stm/lvds.c:1213:3-8: No need to set .owner here. The core will do it.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9457
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/stm/lvds.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/stm/lvds.c b/drivers/gpu/drm/stm/lvds.c
> index 2fa2c81784e9..06f2d7a56cc9 100644
> --- a/drivers/gpu/drm/stm/lvds.c
> +++ b/drivers/gpu/drm/stm/lvds.c
> @@ -1210,7 +1210,6 @@ static struct platform_driver lvds_platform_driver = {
> .remove = lvds_remove,
> .driver = {
> .name = "stm32-display-lvds",
> - .owner = THIS_MODULE,
> .of_match_table = lvds_dt_ids,
> },
> };
Indeed, platform_driver_register() overrides the value of the owner.
Acked-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
Thanks,
Raphaël
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/stm: Remove unnecessary .owner for lvds_platform_driver
2024-07-01 6:23 [PATCH] drm/stm: Remove unnecessary .owner for lvds_platform_driver Jiapeng Chong
2024-07-02 10:00 ` Raphael Gallais-Pou
@ 2024-07-08 13:32 ` Philippe CORNU
1 sibling, 0 replies; 3+ messages in thread
From: Philippe CORNU @ 2024-07-08 13:32 UTC (permalink / raw)
To: Jiapeng Chong, yannick.fertre
Cc: raphael.gallais-pou, maarten.lankhorst, mripard, tzimmermann,
airlied, daniel, mcoquelin.stm32, alexandre.torgue, dri-devel,
linux-stm32, linux-arm-kernel, linux-kernel, Abaci Robot
On 7/1/24 08:23, Jiapeng Chong wrote:
> Remove .owner field if calls are used which set it automatically.
>
> ./drivers/gpu/drm/stm/lvds.c:1213:3-8: No need to set .owner here. The core will do it.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9457
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/stm/lvds.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/stm/lvds.c b/drivers/gpu/drm/stm/lvds.c
> index 2fa2c81784e9..06f2d7a56cc9 100644
> --- a/drivers/gpu/drm/stm/lvds.c
> +++ b/drivers/gpu/drm/stm/lvds.c
> @@ -1210,7 +1210,6 @@ static struct platform_driver lvds_platform_driver = {
> .remove = lvds_remove,
> .driver = {
> .name = "stm32-display-lvds",
> - .owner = THIS_MODULE,
> .of_match_table = lvds_dt_ids,
> },
> };
Hi Jiapeng,
Applied on drm-misc-next.
Many thanks,
Philippe :-)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-08 13:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-01 6:23 [PATCH] drm/stm: Remove unnecessary .owner for lvds_platform_driver Jiapeng Chong
2024-07-02 10:00 ` Raphael Gallais-Pou
2024-07-08 13:32 ` Philippe CORNU
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®