From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
To: Frank Li <Frank.li@nxp.com>
Cc: Chester Lin <chester62515@gmail.com>,
Matthias Brugger <mbrugger@suse.com>,
Ghennadi Procopciuc <ghennadi.procopciuc@oss.nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, s32@nxp.com, imx@lists.linux.dev,
Christophe Lizzi <clizzi@redhat.com>,
Alberto Ruiz <aruizrui@redhat.com>,
Enric Balletbo <eballetb@redhat.com>,
Eric Chanudet <echanude@redhat.com>
Subject: Re: [PATCH] arm64: dts: s32gxxxa-rdb: add RTC module over I2C0
Date: Thu, 10 Apr 2025 17:43:34 +0300 [thread overview]
Message-ID: <9d712c3d-ca69-4a8a-8237-0543fdc2ce5f@oss.nxp.com> (raw)
In-Reply-To: <Z/fWNxhtLb7Mz20R@lizhi-Precision-Tower-5810>
On 4/10/2025 5:31 PM, Frank Li wrote:
> On Thu, Apr 10, 2025 at 04:30:28PM +0300, Ciprian Costea wrote:
>> From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
>>
>> S32G274A-RDB2 and S32G399A-RDB3 boards have a PCA85073A RTC hardware module
>> available and connected over I2C0. Note that the RTC module is not battery
>> backed.
>
> Suggested commit message:
>
> arm64: dts: s32gxxxa-rdb: Add PCA85073A RTC module over I2C0
>
> Add support for the PCA85073A RTC module connected via I2C0 on
> S32G274A-RDB2 and S32G399A-RDB3 boards.
>
> Note that the RTC module is not battery backed.
>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
>
Hello Frank,
Thanks for your suggestion. I will send a V2 accordingly.
Regards,
Ciprian
>>
>> Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
>> ---
>> arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi b/arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi
>> index ba53ec622f0b..4587e1cb8835 100644
>> --- a/arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi
>> @@ -153,6 +153,11 @@ pcal6524: gpio-expander@22 {
>> gpio-controller;
>> #gpio-cells = <2>;
>> };
>> +
>> + pca85073a: rtc@51 {
>> + compatible = "nxp,pca85073a";
>> + reg = <0x51>;
>> + };
>> };
>>
>> &i2c2 {
>> --
>> 2.45.2
>>
prev parent reply other threads:[~2025-04-10 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 13:30 Ciprian Costea
2025-04-10 14:31 ` Frank Li
2025-04-10 14:43 ` Ciprian Marian Costea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d712c3d-ca69-4a8a-8237-0543fdc2ce5f@oss.nxp.com \
--to=ciprianmarian.costea@oss.nxp.com \
--cc=Frank.li@nxp.com \
--cc=aruizrui@redhat.com \
--cc=chester62515@gmail.com \
--cc=clizzi@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetb@redhat.com \
--cc=echanude@redhat.com \
--cc=festevam@gmail.com \
--cc=ghennadi.procopciuc@oss.nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbrugger@suse.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s32@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®