* [PATCH] arm64: dts: s32gxxxa-rdb: add RTC module over I2C0
@ 2025-04-10 13:30 Ciprian Costea
2025-04-10 14:31 ` Frank Li
0 siblings, 1 reply; 3+ messages in thread
From: Ciprian Costea @ 2025-04-10 13:30 UTC (permalink / raw)
To: Chester Lin, Matthias Brugger, Ghennadi Procopciuc, Shawn Guo,
Sascha Hauer, Fabio Estevam, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Pengutronix Kernel Team, linux-arm-kernel, devicetree,
linux-kernel, s32, imx, Christophe Lizzi, Alberto Ruiz,
Enric Balletbo, Eric Chanudet, Ciprian Marian Costea
From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
S32G274A-RDB2 and S32G399A-RDB3 boards have a PCA85073A RTC hardware module
available and connected over I2C0. Note that the RTC module is not battery
backed.
Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
---
arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi b/arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi
index ba53ec622f0b..4587e1cb8835 100644
--- a/arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi
+++ b/arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi
@@ -153,6 +153,11 @@ pcal6524: gpio-expander@22 {
gpio-controller;
#gpio-cells = <2>;
};
+
+ pca85073a: rtc@51 {
+ compatible = "nxp,pca85073a";
+ reg = <0x51>;
+ };
};
&i2c2 {
--
2.45.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: s32gxxxa-rdb: add RTC module over I2C0
2025-04-10 13:30 [PATCH] arm64: dts: s32gxxxa-rdb: add RTC module over I2C0 Ciprian Costea
@ 2025-04-10 14:31 ` Frank Li
2025-04-10 14:43 ` Ciprian Marian Costea
0 siblings, 1 reply; 3+ messages in thread
From: Frank Li @ 2025-04-10 14:31 UTC (permalink / raw)
To: Ciprian Costea
Cc: Chester Lin, Matthias Brugger, Ghennadi Procopciuc, Shawn Guo,
Sascha Hauer, Fabio Estevam, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Pengutronix Kernel Team, linux-arm-kernel,
devicetree, linux-kernel, s32, imx, Christophe Lizzi,
Alberto Ruiz, Enric Balletbo, Eric Chanudet
On Thu, Apr 10, 2025 at 04:30:28PM +0300, Ciprian Costea wrote:
> From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
>
> S32G274A-RDB2 and S32G399A-RDB3 boards have a PCA85073A RTC hardware module
> available and connected over I2C0. Note that the RTC module is not battery
> backed.
Suggested commit message:
arm64: dts: s32gxxxa-rdb: Add PCA85073A RTC module over I2C0
Add support for the PCA85073A RTC module connected via I2C0 on
S32G274A-RDB2 and S32G399A-RDB3 boards.
Note that the RTC module is not battery backed.
Reviewed-by: Frank Li <Frank.Li@nxp.com>
>
> Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
> ---
> arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi b/arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi
> index ba53ec622f0b..4587e1cb8835 100644
> --- a/arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi
> +++ b/arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi
> @@ -153,6 +153,11 @@ pcal6524: gpio-expander@22 {
> gpio-controller;
> #gpio-cells = <2>;
> };
> +
> + pca85073a: rtc@51 {
> + compatible = "nxp,pca85073a";
> + reg = <0x51>;
> + };
> };
>
> &i2c2 {
> --
> 2.45.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: s32gxxxa-rdb: add RTC module over I2C0
2025-04-10 14:31 ` Frank Li
@ 2025-04-10 14:43 ` Ciprian Marian Costea
0 siblings, 0 replies; 3+ messages in thread
From: Ciprian Marian Costea @ 2025-04-10 14:43 UTC (permalink / raw)
To: Frank Li
Cc: Chester Lin, Matthias Brugger, Ghennadi Procopciuc, Shawn Guo,
Sascha Hauer, Fabio Estevam, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Pengutronix Kernel Team, linux-arm-kernel,
devicetree, linux-kernel, s32, imx, Christophe Lizzi,
Alberto Ruiz, Enric Balletbo, Eric Chanudet
On 4/10/2025 5:31 PM, Frank Li wrote:
> On Thu, Apr 10, 2025 at 04:30:28PM +0300, Ciprian Costea wrote:
>> From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
>>
>> S32G274A-RDB2 and S32G399A-RDB3 boards have a PCA85073A RTC hardware module
>> available and connected over I2C0. Note that the RTC module is not battery
>> backed.
>
> Suggested commit message:
>
> arm64: dts: s32gxxxa-rdb: Add PCA85073A RTC module over I2C0
>
> Add support for the PCA85073A RTC module connected via I2C0 on
> S32G274A-RDB2 and S32G399A-RDB3 boards.
>
> Note that the RTC module is not battery backed.
>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
>
Hello Frank,
Thanks for your suggestion. I will send a V2 accordingly.
Regards,
Ciprian
>>
>> Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
>> ---
>> arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi b/arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi
>> index ba53ec622f0b..4587e1cb8835 100644
>> --- a/arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi
>> @@ -153,6 +153,11 @@ pcal6524: gpio-expander@22 {
>> gpio-controller;
>> #gpio-cells = <2>;
>> };
>> +
>> + pca85073a: rtc@51 {
>> + compatible = "nxp,pca85073a";
>> + reg = <0x51>;
>> + };
>> };
>>
>> &i2c2 {
>> --
>> 2.45.2
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-10 14:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-10 13:30 [PATCH] arm64: dts: s32gxxxa-rdb: add RTC module over I2C0 Ciprian Costea
2025-04-10 14:31 ` Frank Li
2025-04-10 14:43 ` Ciprian Marian Costea
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®