* [PATCH] cgroup/dmem: Fix eviction helper reference in dmem_cgroup_try_charge()
@ 2026-09-11 22:08 Karl Mehltretter
2026-09-13 15:48 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Karl Mehltretter @ 2026-09-11 22:08 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Natalie Vock, Tejun Heo,
Johannes Weiner, Michal Koutný
Cc: Karl Mehltretter, cgroups, dri-devel, linux-kernel
The kernel-doc comment of dmem_cgroup_try_charge() refers to
dmem_cgroup_evict_valuable, which does not exist. The name is
dmem_cgroup_state_evict_valuable. Say dmem_cgroup_state_evict_valuable.
Fixes: b168ed458dde ("kernel/cgroup: Add "dmem" memory accounting cgroup")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
kernel/cgroup/dmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/cgroup/dmem.c b/kernel/cgroup/dmem.c
index 4683f3d6802268ddad40bd5d9e10305fc4dfddc5..13dbd083f6dedf83002ee7e7912e1f983e3594f0 100644
--- a/kernel/cgroup/dmem.c
+++ b/kernel/cgroup/dmem.c
@@ -706,7 +706,7 @@ EXPORT_SYMBOL_GPL(dmem_cgroup_uncharge);
*
* When this function fails with -EAGAIN and @ret_limit_pool is non-null, it
* will be set to the pool for which the limit is hit. This can be used for
- * eviction as argument to dmem_cgroup_evict_valuable(). This reference must be freed
+ * eviction as argument to dmem_cgroup_state_evict_valuable(). This reference must be freed
* with @dmem_cgroup_pool_state_put().
*
* Return: 0 on success, -EAGAIN on hitting a limit, or a negative errno on failure.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] cgroup/dmem: Fix eviction helper reference in dmem_cgroup_try_charge()
2026-09-11 22:08 [PATCH] cgroup/dmem: Fix eviction helper reference in dmem_cgroup_try_charge() Karl Mehltretter
@ 2026-09-13 15:48 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2026-09-13 15:48 UTC (permalink / raw)
To: Karl Mehltretter, Maarten Lankhorst, Maxime Ripard, Natalie Vock,
Tejun Heo, Johannes Weiner, mkoutny
Cc: cgroups, dri-devel, linux-kernel
Hello,
Applied to cgroup/for-7.4 with the comment rewrapped.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-13 15:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-11 22:08 [PATCH] cgroup/dmem: Fix eviction helper reference in dmem_cgroup_try_charge() Karl Mehltretter
2026-09-13 15:48 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®