Re: [PATCH 2/3] soc: qcom: pmic_glink: Add GIO pmic_glink instance

[Fenglin Wu <fenglin.wu@oss.qualcomm.com>]

On 11/12/2026 9:11 AM, Fenglin Wu wrote:
> 
> 
> On 11/11/2026 9:14 PM, Jeff Roach wrote:
>> Hi Fenglin,
>>
>> I tried this series on an HP OmniBook X 16 (X2 Elite "Mahua", DT boot,
>> qcom,glymur-pmic-glink, 7.3-based kernel, firmware F.04). The RTC part
>> works: rtc-qcom-gio reads the correct UTC time.
>>
>> But UCSI breaks when pmic_glink_gio is bound, although the commit
>> message says ucsi stays on the legacy interface:
>>
>> - pmic_glink_gio loaded at boot: ucsi_glink fails with
>>   "error -ETIMEDOUT: PPM init failed", no typec ports.
>> - pmic_glink_gio blacklisted (patched pmic_glink still loaded): typec
>>   ports and partners come up, plug/unplug is seen.
>> - Same boot, then modprobe pmic_glink_gio: the RTC works and the ports
>>   stay, but UCSI no longer sees any plug or unplug (old partners stay).
>>   USB data and charging still work.
>>
>> Happy to test a fix.
>>
>> Jeff
> 
> Hi Jeff,
> 
> Thanks for testing the changes and reporting the issues.
> 
> I tested with all clients switched to use GIO interface. I confirmed
> that battmgr, UCSI, altmode worked as expected. I should also test the
> hybrid mode of only having RTC used on GIO and others left in PMIC
> Glink. I thought I didn't push those client changes so those drivers
> were not impacted and they should work as before.
> 
> I will test it this way and get back.
> 
> Thanks
> Fenglin

Hi Jeff,

My initial impression was that the SoCCP battery management firmware
might not handle this hybrid mode (GIO + legacy OPCODE) well. Enabling
the GIO alert might cause the charger firmware to select the GIO
interface over the legacy OPCODE by default. I made a simple change to
prevent the global alert from being enabled, and the issue you mentioned
was resolved at my side. This will not impact RTC driver anyway, as RTC
doesn't need to handle alert messages.

Could you try this on your side? If it works there as well, I can
discuss it with the firmware team and come up with a formal fix when
pushing next patch.


diff --git a/drivers/soc/qcom/pmic_glink_gio.c
b/drivers/soc/qcom/pmic_glink_gio.c
index 83656a5758b8..fc5dcc62b200 100644
--- a/drivers/soc/qcom/pmic_glink_gio.c
+++ b/drivers/soc/qcom/pmic_glink_gio.c
@@ -310,14 +310,14 @@ static void pmic_glink_gio_pdr_notify(void *priv,
int state)

 static void pmic_glink_gio_enable_alerts(struct pmic_glink_gio *pgio)
 {
-       __le32 data;
-       int ret;
-
-       data = cpu_to_le32(GIO_CORE_GLOBAL_ALERT_MODE_IBI |
GIO_CORE_GLOBAL_ALERT_EN_BIT);
-
-       ret = regmap_raw_write(pgio->gio->regmap,
GIO_CORE_GLOBAL_ALERT_CTRL_ADDR, &data, 4);
-       if (ret)
-               dev_err(pgio->dev, "GIO turn on global alert failed:
%d\n", ret);
+//     __le32 data;
+//     int ret;
+//
+//     data = cpu_to_le32(GIO_CORE_GLOBAL_ALERT_MODE_IBI |
GIO_CORE_GLOBAL_ALERT_EN_BIT);
+//
+//     ret = regmap_raw_write(pgio->gio->regmap,
GIO_CORE_GLOBAL_ALERT_CTRL_ADDR, &data, 4);
+//     if (ret)
+//             dev_err(pgio->dev, "GIO turn on global alert failed:
%d\n", ret);
 }

Thanks
Fenglin Wu
>