* [PATCH] ARM: dts: qcom-sdx55: Fix the base address of PCIe PHY
@ 2023-12-11 17:24 Manivannan Sadhasivam
2023-12-11 17:26 ` Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2023-12-11 17:24 UTC (permalink / raw)
To: andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, conor+dt
Cc: linux-arm-msm, devicetree, linux-kernel, Manivannan Sadhasivam,
Dmitry Baryshkov, stable
While convering the binding to new format, serdes address specified in the
old binding was used as the base address. This causes a boot hang as the
driver tries to access memory region outside of the specified address. Fix
it!
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: stable@vger.kernel.org # 6.6
Fixes: bb56cff4ac03 ("ARM: dts: qcom-sdx55: switch PCIe QMP PHY to new style of bindings")
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
arch/arm/boot/dts/qcom/qcom-sdx55.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi
index 2aa5089a8513..a88f186fcf03 100644
--- a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi
@@ -436,9 +436,9 @@ pcie_ep: pcie-ep@1c00000 {
status = "disabled";
};
- pcie_phy: phy@1c07000 {
+ pcie_phy: phy@1c06000 {
compatible = "qcom,sdx55-qmp-pcie-phy";
- reg = <0x01c07000 0x2000>;
+ reg = <0x01c06000 0x2000>;
#address-cells = <1>;
#size-cells = <1>;
ranges;
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: qcom-sdx55: Fix the base address of PCIe PHY
2023-12-11 17:24 [PATCH] ARM: dts: qcom-sdx55: Fix the base address of PCIe PHY Manivannan Sadhasivam
@ 2023-12-11 17:26 ` Konrad Dybcio
2023-12-11 17:39 ` Dmitry Baryshkov
2023-12-19 19:33 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2023-12-11 17:26 UTC (permalink / raw)
To: Manivannan Sadhasivam, andersson, robh+dt,
krzysztof.kozlowski+dt, conor+dt
Cc: linux-arm-msm, devicetree, linux-kernel, Dmitry Baryshkov, stable
On 11.12.2023 18:24, Manivannan Sadhasivam wrote:
> While convering the binding to new format, serdes address specified in the
> old binding was used as the base address. This causes a boot hang as the
> driver tries to access memory region outside of the specified address. Fix
> it!
>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: stable@vger.kernel.org # 6.6
> Fixes: bb56cff4ac03 ("ARM: dts: qcom-sdx55: switch PCIe QMP PHY to new style of bindings")
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: qcom-sdx55: Fix the base address of PCIe PHY
2023-12-11 17:24 [PATCH] ARM: dts: qcom-sdx55: Fix the base address of PCIe PHY Manivannan Sadhasivam
2023-12-11 17:26 ` Konrad Dybcio
@ 2023-12-11 17:39 ` Dmitry Baryshkov
2023-12-19 19:33 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2023-12-11 17:39 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linux-arm-msm, devicetree, linux-kernel, stable
On Mon, 11 Dec 2023 at 19:24, Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:
>
> While convering the binding to new format, serdes address specified in the
> old binding was used as the base address. This causes a boot hang as the
> driver tries to access memory region outside of the specified address. Fix
> it!
>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: stable@vger.kernel.org # 6.6
> Fixes: bb56cff4ac03 ("ARM: dts: qcom-sdx55: switch PCIe QMP PHY to new style of bindings")
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> arch/arm/boot/dts/qcom/qcom-sdx55.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi
> index 2aa5089a8513..a88f186fcf03 100644
> --- a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi
> @@ -436,9 +436,9 @@ pcie_ep: pcie-ep@1c00000 {
> status = "disabled";
> };
>
> - pcie_phy: phy@1c07000 {
> + pcie_phy: phy@1c06000 {
> compatible = "qcom,sdx55-qmp-pcie-phy";
> - reg = <0x01c07000 0x2000>;
> + reg = <0x01c06000 0x2000>;
> #address-cells = <1>;
> #size-cells = <1>;
> ranges;
> --
> 2.25.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: qcom-sdx55: Fix the base address of PCIe PHY
2023-12-11 17:24 [PATCH] ARM: dts: qcom-sdx55: Fix the base address of PCIe PHY Manivannan Sadhasivam
2023-12-11 17:26 ` Konrad Dybcio
2023-12-11 17:39 ` Dmitry Baryshkov
@ 2023-12-19 19:33 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2023-12-19 19:33 UTC (permalink / raw)
To: konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, conor+dt,
Manivannan Sadhasivam
Cc: linux-arm-msm, devicetree, linux-kernel, Dmitry Baryshkov, stable
On Mon, 11 Dec 2023 22:54:11 +0530, Manivannan Sadhasivam wrote:
> While convering the binding to new format, serdes address specified in the
> old binding was used as the base address. This causes a boot hang as the
> driver tries to access memory region outside of the specified address. Fix
> it!
>
>
Applied, thanks!
[1/1] ARM: dts: qcom-sdx55: Fix the base address of PCIe PHY
commit: cc6fc55c7ae04ab19b3972f78d3a8b1be32bf533
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-19 19:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-11 17:24 [PATCH] ARM: dts: qcom-sdx55: Fix the base address of PCIe PHY Manivannan Sadhasivam
2023-12-11 17:26 ` Konrad Dybcio
2023-12-11 17:39 ` Dmitry Baryshkov
2023-12-19 19:33 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®