[PATCH] m68k/mac: Revise PowerBook 500 series model name

[PATCH] m68k/mac: Revise PowerBook 500 series model name

[Finn Thain]

The PowerBook 520, 540 and 550 all have macintosh_config->ident == 72
because that's their gestalt ID in MacOS. Hence, Linux describes them all
as "Powerbook 520". Change that to "Powerbook 500 series", which is more
accurate.

Cc: Joshua Thompson <funaho@jurai.org>
Cc: Stan Johnson <userm57@yahoo.com>
Reported-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@linux-m68k.org>
---
 arch/m68k/mac/config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/m68k/mac/config.c b/arch/m68k/mac/config.c
index e324410ef239..6a74a3fecbc9 100644
--- a/arch/m68k/mac/config.c
+++ b/arch/m68k/mac/config.c
@@ -677,7 +677,7 @@ static struct mac_model mac_data_table[] = {
 		.floppy_type	= MAC_FLOPPY_OLD, /* SWIM 2 */
 	}, {
 		.ident		= MAC_MODEL_PB520,
-		.name		= "PowerBook 520",
+		.name		= "PowerBook 500 series",
 		.adb_type	= MAC_ADB_PB2,
 		.via_type	= MAC_VIA_QUADRA,
 		.scsi_type	= MAC_SCSI_OLD,
-- 
2.39.5

Re: [PATCH] m68k/mac: Revise PowerBook 500 series model name

[Geert Uytterhoeven]

Hi Finn,

On Mon, Aug 12, 2024 at 8:56 AM Finn Thain <fthain@linux-m68k.org> wrote:
> The PowerBook 520, 540 and 550 all have macintosh_config->ident == 72
> because that's their gestalt ID in MacOS. Hence, Linux describes them all
> as "Powerbook 520". Change that to "Powerbook 500 series", which is more
> accurate.
>
> Cc: Joshua Thompson <funaho@jurai.org>
> Cc: Stan Johnson <userm57@yahoo.com>
> Reported-by: Stan Johnson <userm57@yahoo.com>
> Signed-off-by: Finn Thain <fthain@linux-m68k.org>

Thanks for your patch!

> --- a/arch/m68k/mac/config.c
> +++ b/arch/m68k/mac/config.c
> @@ -677,7 +677,7 @@ static struct mac_model mac_data_table[] = {
>                 .floppy_type    = MAC_FLOPPY_OLD, /* SWIM 2 */
>         }, {
>                 .ident          = MAC_MODEL_PB520,
> -               .name           = "PowerBook 520",
> +               .name           = "PowerBook 500 series",
>                 .adb_type       = MAC_ADB_PB2,
>                 .via_type       = MAC_VIA_QUADRA,
>                 .scsi_type      = MAC_SCSI_OLD,

This is a user-visible change, through /proc/hardware.
Do you know if any userspace relies on the old string value?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] m68k/mac: Revise PowerBook 500 series model name

[Finn Thain]

[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]


On Sat, 17 Aug 2024, Geert Uytterhoeven wrote:

> On Mon, Aug 12, 2024 at 8:56 AM Finn Thain <fthain@linux-m68k.org> wrote:
> > The PowerBook 520, 540 and 550 all have macintosh_config->ident == 72
> > because that's their gestalt ID in MacOS. Hence, Linux describes them all
> > as "Powerbook 520". Change that to "Powerbook 500 series", which is more
> > accurate.
> >
> > Cc: Joshua Thompson <funaho@jurai.org>
> > Cc: Stan Johnson <userm57@yahoo.com>
> > Reported-by: Stan Johnson <userm57@yahoo.com>
> > Signed-off-by: Finn Thain <fthain@linux-m68k.org>
> 
> Thanks for your patch!
> 
> > --- a/arch/m68k/mac/config.c
> > +++ b/arch/m68k/mac/config.c
> > @@ -677,7 +677,7 @@ static struct mac_model mac_data_table[] = {
> >                 .floppy_type    = MAC_FLOPPY_OLD, /* SWIM 2 */
> >         }, {
> >                 .ident          = MAC_MODEL_PB520,
> > -               .name           = "PowerBook 520",
> > +               .name           = "PowerBook 500 series",
> >                 .adb_type       = MAC_ADB_PB2,
> >                 .via_type       = MAC_VIA_QUADRA,
> >                 .scsi_type      = MAC_SCSI_OLD,
> 
> This is a user-visible change, through /proc/hardware.
> Do you know if any userspace relies on the old string value?
> 

I did a search on sources.debian.org and didn't find anything. OTOH, a 
search for "powerbook" doesn't actually return Michael's packages that 
used to be available for powerbooks...

Anyway, I agree that /proc/hardware should remain stable, so please 
disregard this patch.