From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Mihai Burduselu <michelcatalin@gmail.com>,
tiwai@suse.com, perex@perex.cz
Cc: Jose.Abreu@synopsys.com, alsa-devel@alsa-project.org,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
broonie@kernel.org, s.nawrocki@samsung.com,
colin.king@canonical.com
Subject: Re: [PATCH] ASoC: dwc: remove 'out of memory' message
Date: Sun, 26 Feb 2017 17:03:22 +0900 [thread overview]
Message-ID: <9da9efc3-cd9b-70a5-a764-e8be32e67d13@sakamocchi.jp> (raw)
In-Reply-To: <20170225110323.7506-1-michelcatalin@gmail.com>
Hi,
On Feb 25 2017 20:03, Mihai Burduselu wrote:
> Reported by checkpatch.pl
> Signed-off-by: Mihai Burduselu <michelcatalin@gmail.com>
> ---
> sound/soc/dwc/designware_i2s.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c
> index 9c46e4112026..6479768cc6a1 100644
> --- a/sound/soc/dwc/designware_i2s.c
> +++ b/sound/soc/dwc/designware_i2s.c
> @@ -611,10 +611,8 @@ static int dw_i2s_probe(struct platform_device *pdev)
> const char *clk_id;
>
> dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
> - if (!dev) {
> - dev_warn(&pdev->dev, "kzalloc fail\n");
> + if (!dev)
The line for 'dev_warn()' should be kept.
> return -ENOMEM;
> - }
>
> dw_i2s_dai = devm_kzalloc(&pdev->dev, sizeof(*dw_i2s_dai), GFP_KERNEL);
> if (!dw_i2s_dai)
Regards
Takashi Sakamoto
next prev parent reply other threads:[~2017-02-26 8:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-25 11:03 Mihai Burduselu
2017-02-26 8:03 ` Takashi Sakamoto [this message]
2017-02-28 15:19 ` Takashi Iwai
2017-03-07 12:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9da9efc3-cd9b-70a5-a764-e8be32e67d13@sakamocchi.jp \
--to=o-takashi@sakamocchi.jp \
--cc=Jose.Abreu@synopsys.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michelcatalin@gmail.com \
--cc=perex@perex.cz \
--cc=s.nawrocki@samsung.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®