mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] m68k: sun3: idprom: ERROR: "foo* bar" should be "foo *bar"
       [not found] <20230713080020.72931-1-panzhiai@cdjrlc.com>
@ 2023-07-13  8:02 ` hexingwei001
  2023-07-24  9:00   ` Geert Uytterhoeven
  0 siblings, 1 reply; 2+ messages in thread
From: hexingwei001 @ 2023-07-13  8:02 UTC (permalink / raw)
  To: sammy, geert; +Cc: linux-m68k, linux-kernel

Fix one occurrences of the checkpatch.pl error:
ERROR: "foo* bar" should be "foo *bar"

Signed-off-by: Xingwei He <hexingwei001@208suo.com>
---
  arch/m68k/sun3/idprom.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/m68k/sun3/idprom.c b/arch/m68k/sun3/idprom.c
index 1ace5353d78f..a4c5cd072c87 100644
--- a/arch/m68k/sun3/idprom.c
+++ b/arch/m68k/sun3/idprom.c
@@ -83,7 +83,7 @@ static void __init display_system_type(unsigned char 
machtype)
      prom_halt();
  }

-void sun3_get_model(unsigned char* model)
+void sun3_get_model(unsigned char *model)
  {
      register int i;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] m68k: sun3: idprom: ERROR: "foo* bar" should be "foo *bar"
  2023-07-13  8:02 ` [PATCH] m68k: sun3: idprom: ERROR: "foo* bar" should be "foo *bar" hexingwei001
@ 2023-07-24  9:00   ` Geert Uytterhoeven
  0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2023-07-24  9:00 UTC (permalink / raw)
  To: hexingwei001; +Cc: sammy, linux-m68k, linux-kernel

On Thu, Jul 13, 2023 at 10:09 AM <hexingwei001@208suo.com> wrote:
> Fix one occurrences of the checkpatch.pl error:
> ERROR: "foo* bar" should be "foo *bar"
>
> Signed-off-by: Xingwei He <hexingwei001@208suo.com>

Thanks for your patch!
But obviously you forgot to run scripts/checkpatch.pl on your own patch:

WARNING: From:/Signed-off-by: email name mismatch: 'From:
hexingwei001@208suo.com' != 'Signed-off-by: Xingwei He
<hexingwei001@208suo.com>'

> --- a/arch/m68k/sun3/idprom.c
> +++ b/arch/m68k/sun3/idprom.c
> @@ -83,7 +83,7 @@ static void __init display_system_type(unsigned char
> machtype)
>       prom_halt();
>   }
>
> -void sun3_get_model(unsigned char* model)
> +void sun3_get_model(unsigned char *model)
>   {
>       register int i;

Whitespace-damaged, so it fails to apply.

These problems are present in all your patches, so something is\
wrong in your workflow.  Please test your patches by running
scripts/checkpatch.pl, emailing them to yourself, and trying to
apply them.

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-24  9:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20230713080020.72931-1-panzhiai@cdjrlc.com>
2023-07-13  8:02 ` [PATCH] m68k: sun3: idprom: ERROR: "foo* bar" should be "foo *bar" hexingwei001
2023-07-24  9:00   ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®