* Re: [PATCH] net: enetc: fix an issue about leak system resources
@ 2020-05-04 14:12 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-05-04 14:12 UTC (permalink / raw)
To: Dejin Zheng, netdev
Cc: linux-kernel, Andy Shevchenko, Claudiu Manoil, David S. Miller,
Vladimir Oltean
> the related system resources were not released when enetc_hw_alloc()
> return error in the enetc_pci_mdio_probe(), add iounmap() for error
> handling label "err_hw_alloc" to fix it.
How do you think about a wording variant like the following?
Subject:
[PATCH v2] net: enetc: Complete exception handling in enetc_pci_mdio_probe()
Change description:
A call of the function “enetc_hw_alloc” can fail here.
The corresponding system resources were not released then.
Thus move a call of the function “iounmap” behind
the label “err_hw_alloc”.
Would you like to reduce the labels for this function implementation instead?
Regards,
Markus
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-05-04 14:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-04 14:12 [PATCH] net: enetc: fix an issue about leak system resources Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®