* [PATCH] Added support for a some new buttons in ideapad-laptop driver
@ 2025-03-26 9:16 Gašper Nemgar
2025-03-26 9:23 ` Hans de Goede
2025-03-26 10:31 ` Ilpo Järvinen
0 siblings, 2 replies; 3+ messages in thread
From: Gašper Nemgar @ 2025-03-26 9:16 UTC (permalink / raw)
To: ikepanhc
Cc: hdegoede, ilpo.jarvinen, linux-kernel, platform-driver-x86,
Gašper Nemgar
Added entries to unsuported wmi codes in ideapad_keymap[]
and one check in wmi_nofify() in order to get wmi code 0x13d to trigger platform_profile_cycle() but only if dytc exists.
Signed-off-by: Gašper Nemgar <gasper.nemgar@gmail.com>"
---
drivers/platform/x86/ideapad-laptop.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index 30bd366d7..cd8c38dc8 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -1308,6 +1308,16 @@ static const struct key_entry ideapad_keymap[] = {
/* Specific to some newer models */
{ KE_KEY, 0x3e | IDEAPAD_WMI_KEY, { KEY_MICMUTE } },
{ KE_KEY, 0x3f | IDEAPAD_WMI_KEY, { KEY_RFKILL } },
+ /* Star- (User Asignable Key) */
+ { KE_KEY, 0x44 | IDEAPAD_WMI_KEY, { KEY_PROG1 } },
+ /* Eye */
+ { KE_KEY, 0x45 | IDEAPAD_WMI_KEY, { KEY_PROG3 } },
+ /* Performance toggle also Fn+Q */
+ { KE_KEY, 0x3d | IDEAPAD_WMI_KEY, { KEY_PROG4 } },
+ /* shift + prtsc */
+ { KE_KEY, 0x2d | IDEAPAD_WMI_KEY, { KEY_CUT } },
+ { KE_KEY, 0x29 | IDEAPAD_WMI_KEY, { KEY_TOUCHPAD_TOGGLE } },
+ { KE_KEY, 0x2a | IDEAPAD_WMI_KEY, { KEY_ROOT_MENU } },
{ KE_END },
};
@@ -2094,6 +2104,14 @@ static void ideapad_wmi_notify(struct wmi_device *wdev, union acpi_object *data)
dev_dbg(&wdev->dev, "WMI fn-key event: 0x%llx\n",
data->integer.value);
+ /* performance button triggered by ... */
+ if (data->integer.value == 0x3d) {
+ if (priv->dytc) {
+ platform_profile_cycle();
+ break;
+ }
+ }
+
/* 0x02 FnLock, 0x03 Esc */
if (data->integer.value == 0x02 || data->integer.value == 0x03)
ideapad_fn_lock_led_notify(priv, data->integer.value == 0x02);
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Added support for a some new buttons in ideapad-laptop driver
2025-03-26 9:16 [PATCH] Added support for a some new buttons in ideapad-laptop driver Gašper Nemgar
@ 2025-03-26 9:23 ` Hans de Goede
2025-03-26 10:31 ` Ilpo Järvinen
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2025-03-26 9:23 UTC (permalink / raw)
To: Gašper Nemgar, ikepanhc
Cc: ilpo.jarvinen, linux-kernel, platform-driver-x86
Hi Gašper,
On 26-Mar-25 10:16 AM, Gašper Nemgar wrote:
> Added entries to unsuported wmi codes in ideapad_keymap[]
> and one check in wmi_nofify() in order to get wmi code 0x13d to trigger platform_profile_cycle() but only if dytc exists.
>
> Signed-off-by: Gašper Nemgar <gasper.nemgar@gmail.com>"
Thank you for the new version.
> ---
> drivers/platform/x86/ideapad-laptop.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index 30bd366d7..cd8c38dc8 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -1308,6 +1308,16 @@ static const struct key_entry ideapad_keymap[] = {
> /* Specific to some newer models */
> { KE_KEY, 0x3e | IDEAPAD_WMI_KEY, { KEY_MICMUTE } },
> { KE_KEY, 0x3f | IDEAPAD_WMI_KEY, { KEY_RFKILL } },
> + /* Star- (User Asignable Key) */
> + { KE_KEY, 0x44 | IDEAPAD_WMI_KEY, { KEY_PROG1 } },
> + /* Eye */
> + { KE_KEY, 0x45 | IDEAPAD_WMI_KEY, { KEY_PROG3 } },
> + /* Performance toggle also Fn+Q */
> + { KE_KEY, 0x3d | IDEAPAD_WMI_KEY, { KEY_PROG4 } },
The above 2 lines should be:
/* Performance toggle also Fn+Q, handled inside ideapad_wmi_notify() */
{ KE_IGNORE, 0x3d | IDEAPAD_WMI_KEY },
otherwise this version looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> + /* shift + prtsc */
> + { KE_KEY, 0x2d | IDEAPAD_WMI_KEY, { KEY_CUT } },
> + { KE_KEY, 0x29 | IDEAPAD_WMI_KEY, { KEY_TOUCHPAD_TOGGLE } },
> + { KE_KEY, 0x2a | IDEAPAD_WMI_KEY, { KEY_ROOT_MENU } },
>
> { KE_END },
> };
> @@ -2094,6 +2104,14 @@ static void ideapad_wmi_notify(struct wmi_device *wdev, union acpi_object *data)
> dev_dbg(&wdev->dev, "WMI fn-key event: 0x%llx\n",
> data->integer.value);
>
> + /* performance button triggered by ... */
> + if (data->integer.value == 0x3d) {
> + if (priv->dytc) {
> + platform_profile_cycle();
> + break;
> + }
> + }
> +
> /* 0x02 FnLock, 0x03 Esc */
> if (data->integer.value == 0x02 || data->integer.value == 0x03)
> ideapad_fn_lock_led_notify(priv, data->integer.value == 0x02);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Added support for a some new buttons in ideapad-laptop driver
2025-03-26 9:16 [PATCH] Added support for a some new buttons in ideapad-laptop driver Gašper Nemgar
2025-03-26 9:23 ` Hans de Goede
@ 2025-03-26 10:31 ` Ilpo Järvinen
1 sibling, 0 replies; 3+ messages in thread
From: Ilpo Järvinen @ 2025-03-26 10:31 UTC (permalink / raw)
To: Gašper Nemgar; +Cc: ikepanhc, Hans de Goede, LKML, platform-driver-x86
[-- Attachment #1: Type: text/plain, Size: 2334 bytes --]
On Wed, 26 Mar 2025, Gašper Nemgar wrote:
Hi,
Please add the driver/file specific prefix to shortlog (in Subject). You
can use git log --oneline file
...to see what prefixes people have used before you.
> Added entries to unsuported wmi codes in ideapad_keymap[]
> and one check in wmi_nofify() in order to get wmi code 0x13d to trigger platform_profile_cycle() but only if dytc exists.
>
> Signed-off-by: Gašper Nemgar <gasper.nemgar@gmail.com>"
> ---
Please also properly version the patches when sending them again, vX in
subject and with a changelog underneath this --- line. You can find
plenty of examples about the changelog from the ML archives.
Thanks.
--
i.
> drivers/platform/x86/ideapad-laptop.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index 30bd366d7..cd8c38dc8 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -1308,6 +1308,16 @@ static const struct key_entry ideapad_keymap[] = {
> /* Specific to some newer models */
> { KE_KEY, 0x3e | IDEAPAD_WMI_KEY, { KEY_MICMUTE } },
> { KE_KEY, 0x3f | IDEAPAD_WMI_KEY, { KEY_RFKILL } },
> + /* Star- (User Asignable Key) */
> + { KE_KEY, 0x44 | IDEAPAD_WMI_KEY, { KEY_PROG1 } },
> + /* Eye */
> + { KE_KEY, 0x45 | IDEAPAD_WMI_KEY, { KEY_PROG3 } },
> + /* Performance toggle also Fn+Q */
> + { KE_KEY, 0x3d | IDEAPAD_WMI_KEY, { KEY_PROG4 } },
> + /* shift + prtsc */
> + { KE_KEY, 0x2d | IDEAPAD_WMI_KEY, { KEY_CUT } },
> + { KE_KEY, 0x29 | IDEAPAD_WMI_KEY, { KEY_TOUCHPAD_TOGGLE } },
> + { KE_KEY, 0x2a | IDEAPAD_WMI_KEY, { KEY_ROOT_MENU } },
>
> { KE_END },
> };
> @@ -2094,6 +2104,14 @@ static void ideapad_wmi_notify(struct wmi_device *wdev, union acpi_object *data)
> dev_dbg(&wdev->dev, "WMI fn-key event: 0x%llx\n",
> data->integer.value);
>
> + /* performance button triggered by ... */
> + if (data->integer.value == 0x3d) {
> + if (priv->dytc) {
> + platform_profile_cycle();
> + break;
> + }
> + }
> +
> /* 0x02 FnLock, 0x03 Esc */
> if (data->integer.value == 0x02 || data->integer.value == 0x03)
> ideapad_fn_lock_led_notify(priv, data->integer.value == 0x02);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-26 10:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-26 9:16 [PATCH] Added support for a some new buttons in ideapad-laptop driver Gašper Nemgar
2025-03-26 9:23 ` Hans de Goede
2025-03-26 10:31 ` Ilpo Järvinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®