mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] staging: greybus: remove unnecessary blank line
@ 2023-03-22 10:09 Menna Mahmoud
  2023-03-22 10:14 ` Julia Lawall
  0 siblings, 1 reply; 6+ messages in thread
From: Menna Mahmoud @ 2023-03-22 10:09 UTC (permalink / raw)
  To: gregkh
  Cc: outreachy, johan, elder, vireshk, thierry.reding,
	u.kleine-koenig, greybus-dev, linux-kernel, linux-staging,
	linux-pwm, eng.mennamahmoud.mm

Remove unnecessary blank line before struct as reported
by checkpatch:

" CHECK: Please don't use multiple blank lines "

Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
---
 drivers/staging/greybus/greybus_authentication.h | 1 -
 drivers/staging/greybus/pwm.c                    | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/staging/greybus/greybus_authentication.h b/drivers/staging/greybus/greybus_authentication.h
index 7edc7295b7ab..48b4a9794d3c 100644
--- a/drivers/staging/greybus/greybus_authentication.h
+++ b/drivers/staging/greybus/greybus_authentication.h
@@ -41,7 +41,6 @@
 #define CAP_AUTH_RESULT_CR_NO_KEY	0x03
 #define CAP_AUTH_RESULT_CR_SIG_FAIL	0x04
 
-
 /* IOCTL support */
 struct cap_ioc_get_endpoint_uid {
 	__u8			uid[8];
diff --git a/drivers/staging/greybus/pwm.c b/drivers/staging/greybus/pwm.c
index 3fda172239d2..26d39e08c3b6 100644
--- a/drivers/staging/greybus/pwm.c
+++ b/drivers/staging/greybus/pwm.c
@@ -24,7 +24,6 @@ struct gb_pwm_chip {
 #define pwm_chip_to_gb_pwm_chip(chip) \
 	container_of(chip, struct gb_pwm_chip, chip)
 
-
 static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc)
 {
 	struct gb_pwm_count_response response;
-- 
2.34.1


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] staging: greybus: remove unnecessary blank line
@ 2023-03-19 15:29 Menna Mahmoud
       [not found] ` <1775403.TLkxdtWsSY@suse>
  0 siblings, 1 reply; 6+ messages in thread
From: Menna Mahmoud @ 2023-03-19 15:29 UTC (permalink / raw)
  To: gregkh
  Cc: outreachy, johan, elder, thierry.reding, u.kleine-koenig,
	greybus-dev, linux-pwm, linux-kernel, linux-staging,
	eng.mennamahmoud.mm

Remove unnecessary blank line before struct as reported
by checkpatch:

" CHECK: Please don't use multiple blank lines "

Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
---
 drivers/staging/greybus/pwm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/greybus/pwm.c b/drivers/staging/greybus/pwm.c
index 3fda172239d2..26d39e08c3b6 100644
--- a/drivers/staging/greybus/pwm.c
+++ b/drivers/staging/greybus/pwm.c
@@ -24,7 +24,6 @@ struct gb_pwm_chip {
 #define pwm_chip_to_gb_pwm_chip(chip) \
 	container_of(chip, struct gb_pwm_chip, chip)
 
-
 static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc)
 {
 	struct gb_pwm_count_response response;
-- 
2.34.1


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] staging: greybus: add blank line after struct
@ 2023-03-19 11:41 Menna Mahmoud
  2023-03-19 11:41 ` [PATCH] staging: greybus: remove unnecessary blank line Menna Mahmoud
  0 siblings, 1 reply; 6+ messages in thread
From: Menna Mahmoud @ 2023-03-19 11:41 UTC (permalink / raw)
  To: gregkh
  Cc: outreachy, vireshk, johan, elder, greybus-dev, linux-kernel,
	linux-staging, eng.mennamahmoud.mm

add blank line after struct for readability as
reported by checkpatch script

" CHECK: Please use a blank line after function/struct/union/enum
declarations"

Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
---
 drivers/staging/greybus/gbphy.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/greybus/gbphy.h b/drivers/staging/greybus/gbphy.h
index d4a225b76338..1de510499480 100644
--- a/drivers/staging/greybus/gbphy.h
+++ b/drivers/staging/greybus/gbphy.h
@@ -15,6 +15,7 @@ struct gbphy_device {
 	struct list_head list;
 	struct device dev;
 };
+
 #define to_gbphy_dev(d) container_of(d, struct gbphy_device, dev)
 
 static inline void *gb_gbphy_get_data(struct gbphy_device *gdev)
@@ -43,6 +44,7 @@ struct gbphy_driver {
 
 	struct device_driver driver;
 };
+
 #define to_gbphy_driver(d) container_of(d, struct gbphy_driver, driver)
 
 int gb_gbphy_register_driver(struct gbphy_driver *driver,
-- 
2.34.1


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-03-22 10:16 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-22 10:09 [PATCH] staging: greybus: remove unnecessary blank line Menna Mahmoud
2023-03-22 10:14 ` Julia Lawall
2023-03-22 10:16   ` Menna Mahmoud
  -- strict thread matches above, loose matches on Subject: below --
2023-03-19 15:29 Menna Mahmoud
     [not found] ` <1775403.TLkxdtWsSY@suse>
2023-03-19 16:15   ` Menna Mahmoud
2023-03-19 11:41 [PATCH] staging: greybus: add blank line after struct Menna Mahmoud
2023-03-19 11:41 ` [PATCH] staging: greybus: remove unnecessary blank line Menna Mahmoud

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®