mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: zhenwei pi <pizhenwei@bytedance.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: stefanha@redhat.com, mst@redhat.com, jasowang@redhat.com,
	xuanzhuo@linux.alibaba.com,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH v2 1/2] virtio: abstract virtqueue related methods
Date: Wed, 17 May 2023 15:43:03 +0800	[thread overview]
Message-ID: <9e4702f2-5473-2139-3858-ae58817bc7b5@bytedance.com> (raw)
In-Reply-To: <ZGSEq197W8VvOWCc@infradead.org>



On 5/17/23 15:39, Christoph Hellwig wrote:
> On Wed, May 17, 2023 at 10:54:23AM +0800, zhenwei pi wrote:
>> All the vring based virtqueue methods could be abstratct in theory,
>> MST suggested that add/get bufs and kick functions are quite perfmance
>> sensitive, so export these functions from virtio_ring.ko, drivers
>> still call them in a fast path.
> 
> Who is going to use this?  And why do you think every virtio users
> would want to pay for indirect calls just for your shiny new feature?
> 
> This seems like an amazingly bad idea to me.

Hi,

I have a plan to introduce 'Virtio Over Fabrics'(TCP&RDMA) as Virtio 
transport, as mentioned in cover letter of this series:
3 weeks ago, I posted a proposal 'Virtio Over Fabrics':
https://lists.oasis-open.org/archives/virtio-comment/202304/msg00442.html

Jason and Stefan pointed out that a non-vring based virtqueue has a
chance to overwrite virtqueue instead of using vring virtqueue.

-- 
zhenwei pi

  reply	other threads:[~2023-05-17  7:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-17  2:54 [PATCH v2 0/2] " zhenwei pi
2023-05-17  2:54 ` [PATCH v2 1/2] " zhenwei pi
2023-05-17  6:57   ` kernel test robot
2023-05-17  7:10   ` kernel test robot
2023-05-17  7:39   ` Christoph Hellwig
2023-05-17  7:43     ` zhenwei pi [this message]
2023-05-17  7:46       ` Christoph Hellwig
2023-05-17  8:35         ` zhenwei pi
2023-05-17 10:39           ` Michael S. Tsirkin
2023-05-18  0:47             ` zhenwei pi
2023-05-18 10:09               ` Michael S. Tsirkin
2023-05-18 11:01                 ` zhenwei pi
2023-05-17 17:59   ` kernel test robot
2023-05-17  2:54 ` [PATCH v2 2/2] tools/virtio: implement virtqueue in test zhenwei pi
2023-05-17  3:46 ` [PATCH v2 0/2] virtio: abstract virtqueue related methods Michael S. Tsirkin
2023-05-17  3:51   ` zhenwei pi
2023-05-17  3:57     ` Michael S. Tsirkin
2023-05-17  4:58       ` zhenwei pi
2023-05-17  6:10         ` Michael S. Tsirkin
2023-05-17  6:21           ` zhenwei pi
2023-05-17 10:13             ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e4702f2-5473-2139-3858-ae58817bc7b5@bytedance.com \
    --to=pizhenwei@bytedance.com \
    --cc=hch@infradead.org \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®