From: "Jon Smirl" <jonsmirl@gmail.com>
To: "Paulo Marques" <pmarques@grupopie.com>
Cc: "Alan Cox" <alan@lxorguk.ukuu.org.uk>,
"Theodore Tso" <tytso@mit.edu>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: tty's use of file_list_lock and file_move
Date: Tue, 11 Jul 2006 09:42:08 -0400 [thread overview]
Message-ID: <9e4733910607110642p598e2288x93302d79aa22377f@mail.gmail.com> (raw)
In-Reply-To: <44B3A484.5000002@grupopie.com>
On 7/11/06, Paulo Marques <pmarques@grupopie.com> wrote:
> Jon Smirl wrote:
> >[...]
> > extern struct tty_driver *ptm_driver; /* Unix98 pty masters; for /dev/ptmx */
> > @@ -158,21 +157,21 @@ static struct tty_struct *alloc_tty_stru
> > {
> > struct tty_struct *tty;
> >
> > - tty = kmalloc(sizeof(struct tty_struct), GFP_KERNEL);
> > - if (tty)
> > - memset(tty, 0, sizeof(struct tty_struct));
> > + tty = kmalloc(sizeof(*tty), GFP_KERNEL);
> ^^^^^^^
> kzalloc?
It needs to be cleaned up. Right now it clears the struct twice before
using it, once in tty_alloc and another in tty_init.
> I don't know this code very well, so you might be actually changing the
> initialization here. On the other hand, this might be just a simple bug...
--
Jon Smirl
jonsmirl@gmail.com
next prev parent reply other threads:[~2006-07-11 13:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 15:10 Jon Smirl
2006-07-10 17:33 ` Alan Cox
2006-07-10 17:27 ` Jon Smirl
2006-07-10 18:05 ` Alan Cox
2006-07-10 18:09 ` Jon Smirl
2006-07-10 23:18 ` Alan Cox
2006-07-10 22:35 ` Jon Smirl
2006-07-10 23:15 ` Alan Cox
2006-07-10 23:04 ` Jon Smirl
2006-07-10 23:49 ` Jon Smirl
2006-07-11 1:29 ` Theodore Tso
2006-07-11 2:16 ` Jon Smirl
2006-07-11 10:12 ` Alan Cox
2006-07-11 12:28 ` Jon Smirl
2006-07-11 13:15 ` Paulo Marques
2006-07-11 13:42 ` Jon Smirl [this message]
2006-07-11 3:33 ` Jon Smirl
2006-07-11 19:52 ` Russell King
2006-07-11 19:44 ` Russell King
2006-07-11 22:08 ` Jon Smirl
2006-07-11 22:37 ` Alan Cox
2006-07-11 23:28 ` Paul Fulghum
2006-07-12 0:00 ` Jon Smirl
2006-07-11 23:50 ` Jon Smirl
2006-07-12 3:55 ` Jon Smirl
2006-07-12 11:37 ` Alan Cox
2006-07-10 23:39 ` Theodore Tso
2006-07-11 0:25 ` Jon Smirl
2006-07-12 6:27 ` Pekka Enberg
2006-07-12 11:19 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e4733910607110642p598e2288x93302d79aa22377f@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=pmarques@grupopie.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®