From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] soc: qcom: geni-se: Increase MAX_GENI_CFG_RAMn_CNT to 1020
Date: Mon, 15 Jun 2026 14:00:40 +0200 [thread overview]
Message-ID: <9e57f91b-8f80-41d4-b50f-31c900cb0fd0@oss.qualcomm.com> (raw)
In-Reply-To: <5363525f-9440-49bd-83db-242a7ed4e15d@oss.qualcomm.com>
On 6/15/26 2:00 PM, Konrad Dybcio wrote:
> On 6/15/26 7:28 AM, Viken Dadhaniya wrote:
>>
>>
>> On 6/9/2026 8:40 PM, Konrad Dybcio wrote:
>>> On 5/22/26 9:21 AM, Viken Dadhaniya wrote:
>>>> The current MAX_GENI_CFG_RAMn_CNT value of 455 is insufficient for
>>>> certain Qualcomm SoCs whose GENI firmware requires up to 1020 RAM
>>>> entries, causing incorrect bounds checking and preventing firmware
>>>> loading on those targets.
>>>>
>>>> Increase MAX_GENI_CFG_RAMn_CNT to 1020 to match the hardware-supported
>>>> limit and ensure correct handling of configuration RAM regions across
>>>> GENI-based SE blocks.
>>>>
>>>> Signed-off-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>
>>>> ---
>>>> drivers/soc/qcom/qcom-geni-se.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c
>>>> index cd1779b6a91a..d0810960f3da 100644
>>>> --- a/drivers/soc/qcom/qcom-geni-se.c
>>>> +++ b/drivers/soc/qcom/qcom-geni-se.c
>>>> @@ -152,7 +152,7 @@ struct se_fw_hdr {
>>>> /*Magic numbers*/
>>>> #define SE_MAGIC_NUM 0x57464553
>>>>
>>>> -#define MAX_GENI_CFG_RAMn_CNT 455
>>>> +#define MAX_GENI_CFG_RAMn_CNT 1020
>>>
>>> Is there any SoC where this could overflow the register space
>>> (you say "certain Qualcomm SoCs")?
>>
>> Yes, on Talos (QCS615), the firmware image needs more than 455 CFG RAM
>> entries, so the previous limit could overflow.
>
> What I'm asking is whether the size of the RAM on any of the SoCs
> is less than 455 (the previous limit)
*Less than 1020 (the new limit), of course..
Konrad
next prev parent reply other threads:[~2026-06-15 12:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 7:21 Viken Dadhaniya
2026-06-09 15:10 ` Konrad Dybcio
2026-06-15 5:28 ` Viken Dadhaniya
2026-06-15 12:00 ` Konrad Dybcio
2026-06-15 12:00 ` Konrad Dybcio [this message]
2026-06-22 17:15 ` Viken Dadhaniya
2026-06-23 6:50 ` Konrad Dybcio
2026-06-30 12:22 ` Viken Dadhaniya
2026-06-30 12:59 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e57f91b-8f80-41d4-b50f-31c900cb0fd0@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viken.dadhaniya@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®