From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Christian Marangi <ansuelsmth@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH] soc: qcom: smem: fix qcom_smem_is_available and check if __smem is valid
Date: Fri, 21 Nov 2025 14:51:11 +0100 [thread overview]
Message-ID: <9e79b63b-82c4-4e20-872e-1dfc1c1139a9@oss.qualcomm.com> (raw)
In-Reply-To: <20251121091125.6289-1-ansuelsmth@gmail.com>
On 11/21/25 10:11 AM, Christian Marangi wrote:
> Commit 7a94d5f31b54 ("soc: qcom: smem: better track SMEM uninitialized
> state") changed the usage of __smem and init now as an error pointer
> instead of NULL.
>
> qcom_smem_is_available() wasn't updated to reflect this change and also
> .qcom_smem_remove doesn't reset it on module exit.
>
> While at it also proced other expoert symbol if __smem is not set to a
> correct pointer.
I think that's a separate issue where we should inspect the impact
(or just mention "please call qcom_smem_is_available() first, probably)
Konrad
prev parent reply other threads:[~2025-11-21 13:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 9:11 Christian Marangi
2025-11-21 13:51 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e79b63b-82c4-4e20-872e-1dfc1c1139a9@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®