mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bastien Curutchet <bastien.curutchet@bootlin.com>
To: David Lechner <david@lechnology.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Herve Codina <herve.codina@bootlin.com>,
	Christopher Cordahi <christophercordahi@nanometrics.ca>
Subject: Re: [PATCH] clk: davinci: da8xx-cfgchip: Initialize clk_init_data before use
Date: Wed, 17 Jul 2024 16:46:43 +0200	[thread overview]
Message-ID: <9e8405fb-6e80-4949-ad37-a50a8cd930da@bootlin.com> (raw)
In-Reply-To: <6081230a-2324-4200-a51d-9b7fefc454f8@lechnology.com>

Hi David,

On 7/17/24 16:22, David Lechner wrote:
> On 7/17/24 9:12 AM, Bastien Curutchet wrote:
>> The flag attribute of the struct clk_init_data isn't initialized before
>> the devm_clk_hw_register() call. This can lead to unexpected behavior
>> during registration.
>>
>> Initialize the entire clk_init_data to zero at declaration.
>>
> 
> Probably should add a Fixes: tag.
> 

Sorry I forgot about it, that would be :

Fixes: 58e1e2d2cd89 ("clk: davinci: cfgchip: Add TI DA8XX USB PHY clocks")


Do I need to send a new iteration with it ?

>> Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com>
>> ---
> 
> Reviewed-by: David Lechner <david@lechnology.com>
> 
> 

Best regards,
Bastien

  reply	other threads:[~2024-07-17 14:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-17 14:12 Bastien Curutchet
2024-07-17 14:22 ` David Lechner
2024-07-17 14:46   ` Bastien Curutchet [this message]
2024-07-17 15:54     ` David Lechner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e8405fb-6e80-4949-ad37-a50a8cd930da@bootlin.com \
    --to=bastien.curutchet@bootlin.com \
    --cc=christophercordahi@nanometrics.ca \
    --cc=david@lechnology.com \
    --cc=herve.codina@bootlin.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®