Re: [PATCH] clk: davinci: da8xx-cfgchip: Initialize clk_init_data before use

[David Lechner <david@lechnology.com>]

On 7/17/24 9:46 AM, Bastien Curutchet wrote:
> Hi David,
> 
> On 7/17/24 16:22, David Lechner wrote:
>> On 7/17/24 9:12 AM, Bastien Curutchet wrote:
>>> The flag attribute of the struct clk_init_data isn't initialized before
>>> the devm_clk_hw_register() call. This can lead to unexpected behavior
>>> during registration.
>>>
>>> Initialize the entire clk_init_data to zero at declaration.
>>>
>>
>> Probably should add a Fixes: tag.
>>
> 
> Sorry I forgot about it, that would be :
> 
> Fixes: 58e1e2d2cd89 ("clk: davinci: cfgchip: Add TI DA8XX USB PHY clocks")
> 
> 
> Do I need to send a new iteration with it ?

That's ultimately up to Stephen, I guess, since he is usually the one
picking up the patches. But I think it wouldn't hurt if you did.

> 
>>> Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com>
>>> ---
>>
>> Reviewed-by: David Lechner <david@lechnology.com>
>>
>>
> 
> Best regards,
> Bastien