mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Boris Petkov" <petkovbb@googlemail.com>
To: "Tejun Heo" <tj@kernel.org>
Cc: "Nick Warne" <nick@ukfsn.org>,
	linux-kernel@vger.kernel.org, "D Bray" <db1986@internetdog.org>,
	"IDE/ATA development list" <linux-ide@vger.kernel.org>
Subject: Re: New CD/DVD reports 'Can Play Audio NO'
Date: Tue, 14 Oct 2008 10:26:19 +0200	[thread overview]
Message-ID: <9ea470500810140126v3058d99dn47768834bd087111@mail.gmail.com> (raw)
In-Reply-To: <48F441F0.90408@kernel.org>

On Tue, Oct 14, 2008 at 8:53 AM, Tejun Heo <tj@kernel.org> wrote:
> Nick Warne wrote:
>> /messages
>> Oct  5 11:54:13 sauron kernel: ata5: PATA max UDMA/133 cmd 0x1f0 ctl
>> 0x3f6 bmdma 0xf400 irq 14
>> Oct  5 11:54:13 sauron kernel: ata6: PATA max
>> UDMA/133 cmd 0x170 ctl 0x376 bmdma 0xf408 irq 15
>> Oct  5 11:54:13 sauron kernel: ata5.00: ATAPI: TSSTcorp CDDVDW
>> SH-S202J, SB00, max UDMA/66
>> Oct  5 11:54:13 sauron kernel: ata5.01: ATAPI: Optiarc DVD RW AD-7200A,
>> 1.06, max UDMA/66
>> Oct  5 11:54:13 sauron kernel: ata5.00: configured for UDMA/66
>> Oct  5 11:54:13 sauron kernel: ata5.01: configured for
>> UDMA/66
>>
>> /syslog
>> Oct  5 11:54:13 sauron kernel: sr0: scsi3-mmc drive: 48x/48x writer
>> dvd-ram cd/rw xa/form2 cdda tray
>> Oct  5 11:54:13 sauron kernel: sr1:
>> scsi3-mmc drive: 48x/48x writer dvd-ram cd/rw xa/form2 cdda tray
>>
>> /proc/sys/dev/cdrom/info
>>
>> drive name:             sr1     sr0
>> drive speed:            48      48
>> drive # of slots:       1       1
>> Can close tray:         1       1
>> Can open tray:          1       1
>> Can lock tray:          1       1
>> Can change speed:       1       1
>> Can select disk:        0       0
>> Can read multisession:  1       1
>> Can read MCN:           1       1
>> Reports media changed:  1       1
>> Can play audio:         1       1
>> Can write CD-R:         1       1
>> Can write CD-RW:        1       1
>> Can read DVD:           1       1
>> Can write DVD-R:        1       1
>> Can write DVD-RAM:      1       1
>> Can read MRW:           1       1
>> Can write MRW:          1       1
>> Can write RAM:          1       1
>
> Thanks.  sr.c just doesn't check whether the drive reports audio play
> capability or not.  It just sets it while ide-cd actually checks for
> the capability.  The drive is not reporting it while it can so ide-cd
> needs blacklist entry for it.  Now that idecd has blacklist entry, all
> should be fine.  Eh... I'm not sure whether we need to update sr to
> follow what ide-cd is doing or not.
>
> Thanks.

Actually, as I already pointed out, I'm not at all happy with blacklisting
stuff. What sounds more sane to me (and this is only me) would be what sr.c
does: assume that per se the drive can play audio and try to play it. But how
many drives are there that cannot play audio, aka, would it be a safe assumption
to say that their number is so diminishingly small that it would be better to
announce that a drive can play audio by default and fail graciously in the
_very_ seldom case it actually cannot ...

-- 
Regards/Gruss,
Boris

  reply	other threads:[~2008-10-14  8:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-04  9:33 Nick Warne
2008-10-05  3:09 ` Tejun Heo
2008-10-05  9:41   ` D Bray
2009-02-04 15:34     ` D Bray
2008-10-05 11:08   ` Nick Warne
2008-10-14  6:53     ` Tejun Heo
2008-10-14  8:26       ` Boris Petkov [this message]
2008-10-14  8:50         ` Tejun Heo
2008-10-14  9:03           ` Boris Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ea470500810140126v3058d99dn47768834bd087111@mail.gmail.com \
    --to=petkovbb@googlemail.com \
    --cc=db1986@internetdog.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nick@ukfsn.org \
    --cc=petkovbb@gmail.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®