mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Boris Petkov" <petkovbb@googlemail.com>
To: "Tejun Heo" <tj@kernel.org>
Cc: "Nick Warne" <nick@ukfsn.org>,
	linux-kernel@vger.kernel.org, "D Bray" <db1986@internetdog.org>,
	"IDE/ATA development list" <linux-ide@vger.kernel.org>,
	"Bartlomiej Zolnierkiewicz" <bzolnier@gmail.com>
Subject: Re: New CD/DVD reports 'Can Play Audio NO'
Date: Tue, 14 Oct 2008 11:03:01 +0200	[thread overview]
Message-ID: <9ea470500810140203l56cbc1d3i9a798580efe91867@mail.gmail.com> (raw)
In-Reply-To: <48F45D70.7000904@kernel.org>

[..]

>>> Thanks.  sr.c just doesn't check whether the drive reports audio play
>>> capability or not.  It just sets it while ide-cd actually checks for
>>> the capability.  The drive is not reporting it while it can so ide-cd
>>> needs blacklist entry for it.  Now that idecd has blacklist entry, all
>>> should be fine.  Eh... I'm not sure whether we need to update sr to
>>> follow what ide-cd is doing or not.
>>>
>>> Thanks.
>>
>> Actually, as I already pointed out, I'm not at all happy with blacklisting
>> stuff. What sounds more sane to me (and this is only me) would be what sr.c
>> does: assume that per se the drive can play audio and try to play it. But how
>> many drives are there that cannot play audio, aka, would it be a safe assumption
>> to say that their number is so diminishingly small that it would be better to
>> announce that a drive can play audio by default and fail graciously in the
>> _very_ seldom case it actually cannot ...
>>
>
> Hmm... I don't know.  I think the flag indicates whether the drive has
> DAC and analog audio output, right?

Currently, ide-cd checks the AudioPlay bit advertized in the CD-ROM Capabilities
and Mechanical Status Page.

> I have quite some SATA drives which
> don't have audio output at all.  I haven't check what they report on the
> mode sense page yet.  Eh... well, having the bit set when the drive
> doesn't support it doesn't hurt too much (yet).  Bartlomiej, what do you
> think?

-- 
Regards/Gruss,
Boris

      reply	other threads:[~2008-10-14  9:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-04  9:33 Nick Warne
2008-10-05  3:09 ` Tejun Heo
2008-10-05  9:41   ` D Bray
2009-02-04 15:34     ` D Bray
2008-10-05 11:08   ` Nick Warne
2008-10-14  6:53     ` Tejun Heo
2008-10-14  8:26       ` Boris Petkov
2008-10-14  8:50         ` Tejun Heo
2008-10-14  9:03           ` Boris Petkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ea470500810140203l56cbc1d3i9a798580efe91867@mail.gmail.com \
    --to=petkovbb@googlemail.com \
    --cc=bzolnier@gmail.com \
    --cc=db1986@internetdog.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nick@ukfsn.org \
    --cc=petkovbb@gmail.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®