From: Michal Simek <michal.simek@amd.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
michal.simek@xilinx.com, git@xilinx.com,
Sam Bobrowicz <sam@elite-embedded.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Steve Longerbeam <slongerbeam@gmail.com>,
"open list:V4L2 CAMERA SENSOR DRIVERS"
<linux-media@vger.kernel.org>
Subject: Re: [PATCH] media: ov5640: fix get_light_freq on auto
Date: Fri, 22 Nov 2024 09:28:33 +0100 [thread overview]
Message-ID: <9ecd7514-fcf1-4deb-aa1f-6f1d695d76a2@amd.com> (raw)
In-Reply-To: <Zz83Hh6gKCFkxWtI@kekkonen.localdomain>
On 11/21/24 14:35, Sakari Ailus wrote:
> Hi Michal,
>
> On Thu, Nov 21, 2024 at 02:32:16PM +0100, Michal Simek wrote:
>> From: Sam Bobrowicz <sam@elite-embedded.com>
>>
>> Light frequency was not properly returned when in auto
>> mode and the detected frequency was 60Hz.
>>
>> Signed-off-by: Sam Bobrowicz <sam@elite-embedded.com>
>> Signed-off-by: Michal Simek <michal.simek@amd.com>
>> ---
>>
>> drivers/media/i2c/ov5640.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
>> index c1d3fce4a7d3..8566bc2edde9 100644
>> --- a/drivers/media/i2c/ov5640.c
>> +++ b/drivers/media/i2c/ov5640.c
>> @@ -1982,6 +1982,7 @@ static int ov5640_get_light_freq(struct ov5640_dev *sensor)
>> light_freq = 50;
>> } else {
>> /* 60Hz */
>> + light_freq = 60;
>
> Any idea where this issue was introduced?
>
> It'd be good to add Fixes: and Cc: stable to this.
It was there from beginning. I have sent v2 with this updated.
M
prev parent reply other threads:[~2024-11-22 8:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 13:32 Michal Simek
2024-11-21 13:35 ` Sakari Ailus
2024-11-22 8:28 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ecd7514-fcf1-4deb-aa1f-6f1d695d76a2@amd.com \
--to=michal.simek@amd.com \
--cc=git@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=sakari.ailus@linux.intel.com \
--cc=sam@elite-embedded.com \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®