* [PATCH] media: ov5640: fix get_light_freq on auto
@ 2024-11-21 13:32 Michal Simek
2024-11-21 13:35 ` Sakari Ailus
0 siblings, 1 reply; 3+ messages in thread
From: Michal Simek @ 2024-11-21 13:32 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git
Cc: Sam Bobrowicz, Mauro Carvalho Chehab, Sakari Ailus,
Steve Longerbeam, open list:V4L2 CAMERA SENSOR DRIVERS
From: Sam Bobrowicz <sam@elite-embedded.com>
Light frequency was not properly returned when in auto
mode and the detected frequency was 60Hz.
Signed-off-by: Sam Bobrowicz <sam@elite-embedded.com>
Signed-off-by: Michal Simek <michal.simek@amd.com>
---
drivers/media/i2c/ov5640.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index c1d3fce4a7d3..8566bc2edde9 100644
--- a/drivers/media/i2c/ov5640.c
+++ b/drivers/media/i2c/ov5640.c
@@ -1982,6 +1982,7 @@ static int ov5640_get_light_freq(struct ov5640_dev *sensor)
light_freq = 50;
} else {
/* 60Hz */
+ light_freq = 60;
}
}
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: ov5640: fix get_light_freq on auto
2024-11-21 13:32 [PATCH] media: ov5640: fix get_light_freq on auto Michal Simek
@ 2024-11-21 13:35 ` Sakari Ailus
2024-11-22 8:28 ` Michal Simek
0 siblings, 1 reply; 3+ messages in thread
From: Sakari Ailus @ 2024-11-21 13:35 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, monstr, michal.simek, git, Sam Bobrowicz,
Mauro Carvalho Chehab, Steve Longerbeam,
open list:V4L2 CAMERA SENSOR DRIVERS
Hi Michal,
On Thu, Nov 21, 2024 at 02:32:16PM +0100, Michal Simek wrote:
> From: Sam Bobrowicz <sam@elite-embedded.com>
>
> Light frequency was not properly returned when in auto
> mode and the detected frequency was 60Hz.
>
> Signed-off-by: Sam Bobrowicz <sam@elite-embedded.com>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> drivers/media/i2c/ov5640.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
> index c1d3fce4a7d3..8566bc2edde9 100644
> --- a/drivers/media/i2c/ov5640.c
> +++ b/drivers/media/i2c/ov5640.c
> @@ -1982,6 +1982,7 @@ static int ov5640_get_light_freq(struct ov5640_dev *sensor)
> light_freq = 50;
> } else {
> /* 60Hz */
> + light_freq = 60;
Any idea where this issue was introduced?
It'd be good to add Fixes: and Cc: stable to this.
> }
> }
>
--
Regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: ov5640: fix get_light_freq on auto
2024-11-21 13:35 ` Sakari Ailus
@ 2024-11-22 8:28 ` Michal Simek
0 siblings, 0 replies; 3+ messages in thread
From: Michal Simek @ 2024-11-22 8:28 UTC (permalink / raw)
To: Sakari Ailus
Cc: linux-kernel, monstr, michal.simek, git, Sam Bobrowicz,
Mauro Carvalho Chehab, Steve Longerbeam,
open list:V4L2 CAMERA SENSOR DRIVERS
On 11/21/24 14:35, Sakari Ailus wrote:
> Hi Michal,
>
> On Thu, Nov 21, 2024 at 02:32:16PM +0100, Michal Simek wrote:
>> From: Sam Bobrowicz <sam@elite-embedded.com>
>>
>> Light frequency was not properly returned when in auto
>> mode and the detected frequency was 60Hz.
>>
>> Signed-off-by: Sam Bobrowicz <sam@elite-embedded.com>
>> Signed-off-by: Michal Simek <michal.simek@amd.com>
>> ---
>>
>> drivers/media/i2c/ov5640.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
>> index c1d3fce4a7d3..8566bc2edde9 100644
>> --- a/drivers/media/i2c/ov5640.c
>> +++ b/drivers/media/i2c/ov5640.c
>> @@ -1982,6 +1982,7 @@ static int ov5640_get_light_freq(struct ov5640_dev *sensor)
>> light_freq = 50;
>> } else {
>> /* 60Hz */
>> + light_freq = 60;
>
> Any idea where this issue was introduced?
>
> It'd be good to add Fixes: and Cc: stable to this.
It was there from beginning. I have sent v2 with this updated.
M
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-22 8:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-21 13:32 [PATCH] media: ov5640: fix get_light_freq on auto Michal Simek
2024-11-21 13:35 ` Sakari Ailus
2024-11-22 8:28 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®