From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Neha Malcom Francis <n-francis@ti.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: nm@ti.com, vigneshr@ti.com, kristo@kernel.org, u-kumar1@ti.com
Subject: Re: [PATCH v5 1/3] dt-bindings: misc: esm: Add ESM support for TI K3 devices
Date: Thu, 4 May 2023 08:51:45 +0200 [thread overview]
Message-ID: <9ece615f-0a6b-fff4-e129-ea7ca224a6a8@linaro.org> (raw)
In-Reply-To: <20230503123212.208457-2-n-francis@ti.com>
On 03/05/2023 14:32, Neha Malcom Francis wrote:
> Document the binding for TI K3 ESM (Error Signaling Module) block.
>
> Signed-off-by: Neha Malcom Francis <n-francis@ti.com>
???
You were already asked to keep it and it was in v4, so you had to
explicitly remove it from your git... It takes me time to figure out
what is happening here. But ok, if you do not keep my review, comment
follows.
...
> + ti,esm-pins:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + description:
> + integer array of ESM interrupt pins to route to external event pin
> + which can be used to reset the SoC.
> + minItems: 1
> + maxItems: 255
> +
> +additionalProperties: false
Put aditionalProperties after required:, just like in example-schema.
> +
> +required:
> + - compatible
> + - reg
> + - ti,esm-pins
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-04 6:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 12:32 [PATCH v5 0/3] Add support for ESM Neha Malcom Francis
2023-05-03 12:32 ` [PATCH v5 1/3] dt-bindings: misc: esm: Add ESM support for TI K3 devices Neha Malcom Francis
2023-05-04 6:51 ` Krzysztof Kozlowski [this message]
2023-05-04 7:43 ` Neha Malcom Francis
2023-05-03 12:32 ` [PATCH v5 2/3] arm64: dts: ti: k3-j721e: Add ESM support Neha Malcom Francis
2023-05-03 12:32 ` [PATCH v5 3/3] arm64: dts: ti: k3-j7200: " Neha Malcom Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ece615f-0a6b-fff4-e129-ea7ca224a6a8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=n-francis@ti.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®