mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-kernel@vger.kernel.org, Andi Shyti <andi.shyti@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	devicetree@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	linux-samsung-soc@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Will Deacon <will.deacon@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] arm64: dts: exynos: Remove unneeded unit names in Exynos5433 nodes
Date: Tue, 10 Jan 2017 16:03:53 -0300	[thread overview]
Message-ID: <9ee4d297-51fd-fd37-e4e4-1a939a644201@osg.samsung.com> (raw)
In-Reply-To: <20170110185109.n3x25yxbaarzikcd@kozik-lap>

Hello Krzysztof,

On 01/10/2017 03:51 PM, Krzysztof Kozlowski wrote:

[snip]

>>  
>> -		usbdrd30: usb@15400000  {
>> +		usbdrd30: usb-0  {
> 
> How about "usbdrd" instead of "usb-0"? It would be still quite a generic
> description of a class.
> 
>>  			compatible = "samsung,exynos5250-dwusb3";
>>  			clocks = <&cmu_fsys CLK_ACLK_USBDRD30>,
>>  				<&cmu_fsys CLK_SCLK_USBDRD30>;
>> @@ -1332,7 +1332,7 @@
>>  			status = "disabled";
>>  		};
>>  
>> -		usbhost30: usb@15a00000 {
>> +		usbhost30: usb-1 {
> 
> usbhost?
> 

Indeed, these sounds better so I'll change for them.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

  reply	other threads:[~2017-01-10 19:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10 17:38 [PATCH v2 0/3] arm64: dts: exynos: Fix DTC warnings for Exynos boards Javier Martinez Canillas
2017-01-10 17:38 ` [PATCH v2 1/3] arm64: dts: exynos: Add missing unit name to Exynos7 SoC node Javier Martinez Canillas
2017-01-10 18:47   ` Krzysztof Kozlowski
2017-01-10 19:55     ` Javier Martinez Canillas
2017-02-20 14:00       ` Javier Martinez Canillas
2017-01-10 17:38 ` [PATCH v2 2/3] arm64: dts: exynos: Add missing unit name to Exynos5433 " Javier Martinez Canillas
2017-01-10 17:38 ` [PATCH v2 3/3] arm64: dts: exynos: Remove unneeded unit names in Exynos5433 nodes Javier Martinez Canillas
2017-01-10 18:51   ` Krzysztof Kozlowski
2017-01-10 19:03     ` Javier Martinez Canillas [this message]
2017-01-10 18:42 ` [PATCH v2 0/3] arm64: dts: exynos: Fix DTC warnings for Exynos boards Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ee4d297-51fd-fd37-e4e4-1a939a644201@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=andi.shyti@samsung.com \
    --cc=catalin.marinas@arm.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®