mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-kernel@vger.kernel.org, Andi Shyti <andi.shyti@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	devicetree@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	linux-samsung-soc@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Will Deacon <will.deacon@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] arm64: dts: exynos: Add missing unit name to Exynos7 SoC node
Date: Tue, 10 Jan 2017 16:55:52 -0300	[thread overview]
Message-ID: <e60bf634-d60d-7316-76a9-3b2f2f1480e8@osg.samsung.com> (raw)
In-Reply-To: <20170110184728.2nff4r634ics4wb3@kozik-lap>

Hello Krzysztof,

On 01/10/2017 03:47 PM, Krzysztof Kozlowski wrote:
> On Tue, Jan 10, 2017 at 02:38:30PM -0300, Javier Martinez Canillas wrote:
>> This patch fixes the following DTC warning about a mismatch
>> between a device node reg property and its unit name:
>>
>> Node /soc has a reg or ranges property, but no unit name
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
>>
>>  arch/arm64/boot/dts/exynos/exynos7.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
>> index 80aa60e38237..0d2fedc6ac2f 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
>> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
>> @@ -69,7 +69,7 @@
>>  		method = "smc";
>>  	};
>>  
>> -	soc: soc {
>> +	soc: soc@0 {
> 
> This looks unnatural, like a fix just to silence the DTC. Mostly de do
> not enumerate soc node, although there are few exceptions.
>

Yes, but OTOH arm32 Exynos SoCs just have an empty "ranges" property in their
soc device node (parent and child address space is the same, no translation)
so DTC doesn't complain about the unit address in those.

But others SoCs DTSI with a non-empty ranges property have an unit name in
their soc nodes, i.e for arm64 and arm32:

arch/arm64/boot/dts/marvell/berlin4ct.dtsi

arch/arm/boot/dts/da850.dtsi
 
> I would prefer ignore the warning... however I am happy to hear other opinions.
>

If is wrong/unnatural to have addresses for soc nodes then I think DTC should
be patched to ignore these (like it will be the case for the OPP nodes AFAIU).

> Best regards,
> Krzysztof
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

  reply	other threads:[~2017-01-10 19:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10 17:38 [PATCH v2 0/3] arm64: dts: exynos: Fix DTC warnings for Exynos boards Javier Martinez Canillas
2017-01-10 17:38 ` [PATCH v2 1/3] arm64: dts: exynos: Add missing unit name to Exynos7 SoC node Javier Martinez Canillas
2017-01-10 18:47   ` Krzysztof Kozlowski
2017-01-10 19:55     ` Javier Martinez Canillas [this message]
2017-02-20 14:00       ` Javier Martinez Canillas
2017-01-10 17:38 ` [PATCH v2 2/3] arm64: dts: exynos: Add missing unit name to Exynos5433 " Javier Martinez Canillas
2017-01-10 17:38 ` [PATCH v2 3/3] arm64: dts: exynos: Remove unneeded unit names in Exynos5433 nodes Javier Martinez Canillas
2017-01-10 18:51   ` Krzysztof Kozlowski
2017-01-10 19:03     ` Javier Martinez Canillas
2017-01-10 18:42 ` [PATCH v2 0/3] arm64: dts: exynos: Fix DTC warnings for Exynos boards Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e60bf634-d60d-7316-76a9-3b2f2f1480e8@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=andi.shyti@samsung.com \
    --cc=catalin.marinas@arm.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®