* [PATCH] modpost: fix off by one in is_executable_section()
@ 2023-06-08 8:23 Dan Carpenter
2023-06-08 14:55 ` Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2023-06-08 8:23 UTC (permalink / raw)
To: Quentin Casasnovas
Cc: Masahiro Yamada, Nathan Chancellor, Nick Desaulniers,
Nicolas Schier, Rusty Russell, linux-kbuild, linux-kernel,
kernel-janitors
The > comparison should be >= to prevent an out of bounds array
access.
Fixes: 52dc0595d540 ("modpost: handle relocations mismatch in __ex_table.")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
scripts/mod/modpost.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index d10f5bdcb753..c3cb69c276ae 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1139,7 +1139,7 @@ static Elf_Sym *find_tosym(struct elf_info *elf, Elf_Addr addr, Elf_Sym *sym)
static bool is_executable_section(struct elf_info *elf, unsigned int secndx)
{
- if (secndx > elf->num_sections)
+ if (secndx >= elf->num_sections)
return false;
return (elf->sechdrs[secndx].sh_flags & SHF_EXECINSTR) != 0;
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] modpost: fix off by one in is_executable_section()
2023-06-08 8:23 [PATCH] modpost: fix off by one in is_executable_section() Dan Carpenter
@ 2023-06-08 14:55 ` Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2023-06-08 14:55 UTC (permalink / raw)
To: Dan Carpenter
Cc: Quentin Casasnovas, Nathan Chancellor, Nick Desaulniers,
Nicolas Schier, Rusty Russell, linux-kbuild, linux-kernel,
kernel-janitors
On Thu, Jun 8, 2023 at 6:15 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> The > comparison should be >= to prevent an out of bounds array
> access.
>
> Fixes: 52dc0595d540 ("modpost: handle relocations mismatch in __ex_table.")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
Applied to linux-kbuild.
Thanks.
> scripts/mod/modpost.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index d10f5bdcb753..c3cb69c276ae 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -1139,7 +1139,7 @@ static Elf_Sym *find_tosym(struct elf_info *elf, Elf_Addr addr, Elf_Sym *sym)
>
> static bool is_executable_section(struct elf_info *elf, unsigned int secndx)
> {
> - if (secndx > elf->num_sections)
> + if (secndx >= elf->num_sections)
> return false;
>
> return (elf->sechdrs[secndx].sh_flags & SHF_EXECINSTR) != 0;
> --
> 2.39.2
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-08 14:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-08 8:23 [PATCH] modpost: fix off by one in is_executable_section() Dan Carpenter
2023-06-08 14:55 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®