mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	kernel@savoirfairelinux.com,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Russell King - ARM Linux <linux@armlinux.org.uk>,
	Mark Rutland <mark.rutland@arm.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	kris@embeddedarm.com, Mark Featherston <mark@embeddedarm.com>,
	Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 2/2] ARM: dts: TS-7970: add basic device tree
Date: Tue, 21 Nov 2017 10:37:39 -0500	[thread overview]
Message-ID: <9f24aabd-bf1f-c48f-b997-b0c80e44ca81@savoirfairelinux.com> (raw)
In-Reply-To: <CAOMZO5AFEqk6FcfzJGO6VH0LpF7uFnkmiMYds9y=jajx8ygdZQ@mail.gmail.com>

Hi Fabio,

On 11/20/2017 06:37 PM, Fabio Estevam wrote:
> Hi Sebastien,
> 
> On Mon, Nov 20, 2017 at 7:15 PM, Sebastien Bourdelin
> <sebastien.bourdelin@savoirfairelinux.com> wrote:
> 
>> +&ecspi2 {
>> +       cs-gpios = <
>> +               &gpio5 31 GPIO_ACTIVE_HIGH
>> +               &gpio7 12 GPIO_ACTIVE_HIGH
>> +               &gpio5 18 GPIO_ACTIVE_HIGH
>> +       >;
>> +       pinctrl-names = "default";
>> +       pinctrl-0 = <&pinctrl_ecspi2>;
>> +       status = "okay";
>> +
>> +       spidevfpga: spi@1 {
>> +               compatible = "spidev";
>> +               reg = <1>;
>> +               spi-max-frequency = <1000000>;
> 
> According to drivers/spi/spidev.c:
> 
> /*
> * spidev should never be referenced in DT without a specific
> * compatible string, it is a Linux implementation thing
> * rather than a description of the hardware.
> */
> 

Thanks, you are right!
Just to point it, this warning has been introduced in
956b200a846e324322f6211034c734c65a38e550 in date of march 2015, and it
seems some devices trees whom had been introduced after still use the
"spidev" string only.

  reply	other threads:[~2017-11-21 15:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-20 21:15 [PATCH 1/2] of: documentation: add bindings documentation for TS-7970 Sebastien Bourdelin
2017-11-20 21:15 ` [PATCH 2/2] ARM: dts: TS-7970: add basic device tree Sebastien Bourdelin
2017-11-20 23:37   ` Fabio Estevam
2017-11-21 15:37     ` Sebastien Bourdelin [this message]
2017-11-22 14:04   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f24aabd-bf1f-c48f-b997-b0c80e44ca81@savoirfairelinux.com \
    --to=sebastien.bourdelin@savoirfairelinux.com \
    --cc=broonie@kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kernel@savoirfairelinux.com \
    --cc=kris@embeddedarm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mark@embeddedarm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®