From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Cc: cw00.choi@samsung.com, krzysztof.kozlowski@canonical.com,
b.zolnierkie@samsung.com, a.zummo@towertech.it,
alexandre.belloni@bootlin.com, linux-rtc@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] rtc: max77686: Remove some dead code
Date: Sat, 8 May 2021 18:59:25 +0200 [thread overview]
Message-ID: <9f34ebcd-0c17-cd7f-eb08-52c6c3dc7b03@wanadoo.fr> (raw)
In-Reply-To: <CAOc6etaUPtJqoH9DBDE72nDW7s7iEZHnaJRpKx9zFow02WOZig@mail.gmail.com>
Le 08/05/2021 à 16:38, Edmundo Carmona Antoranz a écrit :
> On Fri, May 7, 2021 at 11:43 PM Christophe JAILLET
> <christophe.jaillet@wanadoo.fr> wrote:
>> if (IS_ERR(info->rtc_dev)) {
>> ret = PTR_ERR(info->rtc_dev);
>> dev_err(&pdev->dev, "Failed to register RTC device: %d\n", ret);
>
> Following the recent conversations, I think it might make sense to do
> dev_err(&pdev->dev, "Failed to register RTC device: %pe\n", info->rtc_dev);
>
> Is that right?
>
Yes, it is right, but it should be done in another patch.
Would you like to give it a try?
CJ
next prev parent reply other threads:[~2021-05-08 16:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 5:43 Christophe JAILLET
2021-05-08 14:38 ` Edmundo Carmona Antoranz
2021-05-08 16:59 ` Christophe JAILLET [this message]
2021-05-09 0:06 ` Edmundo Carmona Antoranz
2021-05-09 21:06 ` Alexandre Belloni
2021-05-10 12:20 ` Krzysztof Kozlowski
2021-05-12 16:13 ` Alexandre Belloni
2021-05-12 16:24 ` Krzysztof Kozlowski
2021-05-12 16:54 ` Alexandre Belloni
2021-05-12 20:02 ` Christophe JAILLET
2021-05-12 21:22 ` Alexandre Belloni
2021-05-10 12:18 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f34ebcd-0c17-cd7f-eb08-52c6c3dc7b03@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=eantoranz@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®